Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-25 11:15:34 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1393274: Correct webpage RTL padding/margins. r=liuche

Browse Source 
Previously, I added a comment to explain why the explicit 0dp padding/margins
are necessary for RTL but since it's required everywhere padding/margins are
used, it's unsustainable and I chose not to do it here.

MozReview-Commit-ID: H7H9xgeLy8b

--HG--
extra : rebase_source : 82c012534ed4d5105cead580c9d7daed82b04b9b
This commit is contained in:
Michael Comella 2017-08-30 13:27:20 -07:00
parent 821599f2b0
commit 41c0b98adf
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
mobile/android/app/src/main/res/layout/activity_stream_webpage_item_row.xml
View File

@ -55,6 +55,8 @@
android:layout_toStartOf="@id/menu" android:layout_toStartOf="@id/menu"
android:paddingLeft="@dimen/activity_stream_base_margin" android:paddingLeft="@dimen/activity_stream_base_margin"
android:paddingStart="@dimen/activity_stream_base_margin" android:paddingStart="@dimen/activity_stream_base_margin"
android:paddingRight="0dp"
android:paddingEnd="0dp"
android:paddingTop="@dimen/activity_stream_base_margin" android:paddingTop="@dimen/activity_stream_base_margin"
android:textAlignment="viewStart" android:textAlignment="viewStart"
android:textColor="@color/activity_stream_subtitle" android:textColor="@color/activity_stream_subtitle"
@ -75,6 +77,8 @@
android:maxLines="3" android:maxLines="3"
android:paddingLeft="@dimen/activity_stream_base_margin" android:paddingLeft="@dimen/activity_stream_base_margin"
android:paddingStart="@dimen/activity_stream_base_margin" android:paddingStart="@dimen/activity_stream_base_margin"
android:paddingRight="0dp"
android:paddingEnd="0dp"
android:textAlignment="viewStart" android:textAlignment="viewStart"
android:textColor="#ff000000" android:textColor="#ff000000"
android:textSize="14sp" android:textSize="14sp"
@ -109,7 +113,10 @@
android:id="@+id/page_source" android:id="@+id/page_source"
android:layout_width="0dp" android:layout_width="0dp"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_marginStart="2dp"
android:layout_marginLeft="2dp" android:layout_marginLeft="2dp"
android:layout_marginRight="0dp"
android:layout_marginEnd="0dp"
android:layout_weight="1" android:layout_weight="1"
android:textAlignment="viewStart" android:textAlignment="viewStart"
android:textColor="@color/activity_stream_subtitle" android:textColor="@color/activity_stream_subtitle"