Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-26 20:30:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1662653: [devtools] Use other experimental properties instead of appearance. r=Honza

Browse Source 
Depends on D93070

Differential Revision: https://phabricator.services.mozilla.com/D93297
This commit is contained in:
Daisuke Akatsuka 2020-10-13 11:29:10 +00:00
parent da6a32c342
commit 41e2c566d4
2 changed files with 30 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
devtools/client/inspector/rules/test/browser_rules_css-compatibility-add-rename-rule.js
View File

@ -14,7 +14,7 @@ const TEST_URI = `
<style>
body {
user-select: none;
-moz-appearance: none;
text-decoration-skip: none;
clip: auto;
}
</style>
@ -32,7 +32,7 @@ const TEST_DATA_INITIAL = [
value: "none",
expected: COMPATIBILITY_TOOLTIP_MESSAGE.default,
},
"-moz-appearance": {
"text-decoration-skip": {
value: "none",
expected: COMPATIBILITY_TOOLTIP_MESSAGE.experimental,
},
@ -73,7 +73,7 @@ const TEST_DATA_ADD_RULE = [
value: "none",
expected: COMPATIBILITY_TOOLTIP_MESSAGE.default,
},
"-moz-appearance": {
"text-decoration-skip": {
value: "none",
expected: COMPATIBILITY_TOOLTIP_MESSAGE.experimental,
},
@ -113,7 +113,7 @@ const TEST_DATA_RENAME_RULE = [
"background-color": {
value: "green",
},
"-moz-appearance": {
"text-decoration-skip": {
value: "none",
expected: COMPATIBILITY_TOOLTIP_MESSAGE.experimental,
},

40
devtools/client/inspector/rules/test/browser_rules_css-compatibility-check-add-fix.js
View File

@ -14,13 +14,26 @@
// universally compatible alias "-webkit-user-select" exists
// alongside.
const TARGET_BROWSERS = [
{
// Chrome doesn't need any prefix for both user-select and text-size-adjust.
id: "chrome",
version: "84",
},
{
// The safari_ios needs -webkit prefix for both properties.
id: "safari_ios",
version: "13",
},
];
const TEST_URI = `
<style>
div {
color: green;
background-color: black;
user-select: none;
-webkit-appearance: none;
text-size-adjust: none;
}
</style>
<div>`;
@ -37,7 +50,7 @@ const TEST_DATA_INITIAL = [
value: "none",
expected: COMPATIBILITY_TOOLTIP_MESSAGE.default,
},
"-webkit-appearance": {
"text-size-adjust": {
value: "none",
expected: COMPATIBILITY_TOOLTIP_MESSAGE.experimental,
},
@ -56,7 +69,7 @@ const TEST_DATA_FIX_USER_SELECT = [
"background-color": { value: "black" },
"user-select": { value: "none" },
"-webkit-user-select": { value: "none" },
"-webkit-appearance": {
"text-size-adjust": {
value: "none",
expected: COMPATIBILITY_TOOLTIP_MESSAGE.experimental,
},
@ -65,10 +78,9 @@ const TEST_DATA_FIX_USER_SELECT = [
},
];
// Appearance is an experimental property with aliases.
// Adding both -webkit and -moz prefix makes it compatible
// on all platforms but will still show an inline warning
// for its experimental status.
// text-size-adjust is an experimental property with aliases.
// Adding -webkit makes it compatible on all platforms but will
// still show an inline warning for its experimental status.
const TEST_DATA_FIX_EXPERIMENTAL_SUPPORTED = [
{
selector: "div",
@ -79,11 +91,7 @@ const TEST_DATA_FIX_EXPERIMENTAL_SUPPORTED = [
"background-color": { value: "black" },
"user-select": { value: "none" },
"-webkit-user-select": { value: "none" },
"-webkit-appearance": {
value: "none",
expected: COMPATIBILITY_TOOLTIP_MESSAGE["experimental-supported"],
},
"-moz-appearance": {
"text-size-adjust": {
value: "none",
expected: COMPATIBILITY_TOOLTIP_MESSAGE["experimental-supported"],
},
@ -93,6 +101,10 @@ const TEST_DATA_FIX_EXPERIMENTAL_SUPPORTED = [
];
add_task(async function() {
await pushPref(
"devtools.inspector.compatibility.target-browsers",
JSON.stringify(TARGET_BROWSERS)
);
await pushPref(
"devtools.inspector.ruleview.inline-compatibility-warning.enabled",
true
@ -109,9 +121,9 @@ add_task(async function() {
await runCSSCompatibilityTests(view, inspector, TEST_DATA_FIX_USER_SELECT);
info(
'Add -moz-appearance: "none" fixing issue but leaving an inline warning of an experimental property'
'Add -webkit-text-size-adjust: "none" fixing issue but leaving an inline warning of an experimental property'
);
await addProperty(view, 1, "-moz-appearance", "none");
await addProperty(view, 1, "-webkit-text-size-adjust", "none");
await runCSSCompatibilityTests(
view,
inspector,