Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-29 07:42:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Stop treating _new as a special window target. No other browser does. Bug 417067, r+sr=jst, a=beltzner

Browse Source
This commit is contained in:
bzbarsky@mit.edu 2008-02-13 21:05:25 -08:00
parent d2a6517917
commit 41f1d79e6e
12 changed files with 12 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
browser/base/content/metaData.js
View File

@ -327,7 +327,6 @@ function checkForLink(elem, htmllocalname)
setInfo("link-target", gMetadataBundle.getString("parentFrameText")); setInfo("link-target", gMetadataBundle.getString("parentFrameText"));
break; break;
case "_blank": case "_blank":
case "_new":
var where = "Window"; var where = "Window";
var newWindowPref = prefs.getIntPref("browser.link.open_newwindow"); var newWindowPref = prefs.getIntPref("browser.link.open_newwindow");
if (newWindowPref == 3) if (newWindowPref == 3)

3
docshell/base/nsDocShell.cpp
View File

@ -2028,8 +2028,7 @@ nsDocShell::FindItemWithName(const PRUnichar * aName,
if (name.LowerCaseEqualsLiteral("_self")) { if (name.LowerCaseEqualsLiteral("_self")) {
foundItem = this; foundItem = this;
} }
else if (name.LowerCaseEqualsLiteral("_blank") || else if (name.LowerCaseEqualsLiteral("_blank"))
name.LowerCaseEqualsLiteral("_new"))
{ {
// Just return null. Caller must handle creating a new window with // Just return null. Caller must handle creating a new window with
// a blank name himself. // a blank name himself.

5
embedding/components/windowwatcher/src/nsWindowWatcher.cpp
View File

@ -738,11 +738,10 @@ nsWindowWatcher::OpenWindowJSInternal(nsIDOMWindow *aParent,
/* allow a window that we found by name to keep its name (important for cases /* allow a window that we found by name to keep its name (important for cases
like _self where the given name is different (and invalid)). Also, _blank like _self where the given name is different (and invalid)). Also, _blank
and _new are not window names. */ is not a window name. */
if (windowNeedsName) if (windowNeedsName)
newDocShellItem->SetName(nameSpecified && newDocShellItem->SetName(nameSpecified &&
!name.LowerCaseEqualsLiteral("_blank") && !name.LowerCaseEqualsLiteral("_blank") ?
!name.LowerCaseEqualsLiteral("_new") ?
name.get() : nsnull); name.get() : nsnull);

2
toolkit/content/tests/chrome/test_largemenu.xul
View File

@ -17,7 +17,7 @@
SimpleTest.waitForExplicitFinish(); SimpleTest.waitForExplicitFinish();
function runTest() function runTest()
{ {
window.open("window_largemenu.xul", "_new", "chrome,width=200,height=200"); window.open("window_largemenu.xul", "_blank", "chrome,width=200,height=200");
} }
</script> </script>

2
toolkit/content/tests/chrome/test_panel_focus.xul
View File

@ -26,7 +26,7 @@ function runTest()
// test can fail on Mac // test can fail on Mac
synthesizeMouse(document.documentElement, 1, 1, { type: "mousemove" }); synthesizeMouse(document.documentElement, 1, 1, { type: "mousemove" });
window.open("window_panel_focus.xul", "_new", "chrome,width=600,height=600"); window.open("window_panel_focus.xul", "_blank", "chrome,width=600,height=600");
} }
</script> </script>

2
toolkit/content/tests/chrome/test_popup_anchor.xul
View File

@ -16,7 +16,7 @@
SimpleTest.waitForExplicitFinish(); SimpleTest.waitForExplicitFinish();
function runTest() function runTest()
{ {
window.open("window_popup_anchor.xul", "_new", "chrome,width=600,height=600"); window.open("window_popup_anchor.xul", "_blank", "chrome,width=600,height=600");
} }
</script> </script>

2
toolkit/content/tests/chrome/test_popup_preventdefault_chrome.xul
View File

@ -17,7 +17,7 @@
SimpleTest.waitForExplicitFinish(); SimpleTest.waitForExplicitFinish();
function runTest() function runTest()
{ {
window.open("window_popup_preventdefault_chrome.xul", "_new", "chrome,width=600,height=600"); window.open("window_popup_preventdefault_chrome.xul", "_blank", "chrome,width=600,height=600");
} }
</script> </script>

2
toolkit/content/tests/widgets/test_menubar.xul
View File

@ -15,7 +15,7 @@
SimpleTest.waitForExplicitFinish(); SimpleTest.waitForExplicitFinish();
function runTest() function runTest()
{ {
window.open("window_menubar.xul", "_new", "width=600,height=600"); window.open("window_menubar.xul", "_blank", "width=600,height=600");
} }
</script> </script>

2
toolkit/content/tests/widgets/test_menuchecks.xul
View File

@ -18,7 +18,7 @@
SimpleTest.waitForExplicitFinish(); SimpleTest.waitForExplicitFinish();
function runTest() function runTest()
{ {
window.open("window_menuchecks.xul", "_new", "width=600,height=600"); window.open("window_menuchecks.xul", "_blank", "width=600,height=600");
} }
</script> </script>

2
toolkit/content/tests/widgets/test_popup_attribute.xul
View File

@ -15,7 +15,7 @@
SimpleTest.waitForExplicitFinish(); SimpleTest.waitForExplicitFinish();
function runTest() function runTest()
{ {
window.open("window_popup_attribute.xul", "_new", "width=600,height=600"); window.open("window_popup_attribute.xul", "_blank", "width=600,height=600");
} }
</script> </script>

2
toolkit/content/tests/widgets/test_popup_button.xul
View File

@ -15,7 +15,7 @@
SimpleTest.waitForExplicitFinish(); SimpleTest.waitForExplicitFinish();
function runTest() function runTest()
{ {
window.open("window_popup_button.xul", "_new", "width=600,height=600"); window.open("window_popup_button.xul", "_blank", "width=600,height=600");
} }
</script> </script>

2
toolkit/content/tests/widgets/test_tooltip.xul
View File

@ -16,7 +16,7 @@
SimpleTest.waitForExplicitFinish(); SimpleTest.waitForExplicitFinish();
function runTest() function runTest()
{ {
window.open("window_tooltip.xul", "_new", "width=600,height=600"); window.open("window_tooltip.xul", "_blank", "width=600,height=600");
} }
</script> </script>