From 42062c43db6ded0847f048855fd72fddc5c2d353 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Thu, 3 May 2018 18:31:54 +0200 Subject: [PATCH] Bug 1458814: Remove unused AnimationValue::mGecko. r=hiro MozReview-Commit-ID: I0TJsSQYe5t --- layout/style/StyleAnimationValue.h | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/layout/style/StyleAnimationValue.h b/layout/style/StyleAnimationValue.h index 1ea1f55d6545..4068428cfb05 100644 --- a/layout/style/StyleAnimationValue.h +++ b/layout/style/StyleAnimationValue.h @@ -81,8 +81,7 @@ struct AnimationValue // Return the transform list as a RefPtr. already_AddRefed GetTransformList() const; - // Return the scale for mGecko or mServo, which are calculated with - // reference to aFrame. + // Return the scale for mServo, which is calculated with reference to aFrame. mozilla::gfx::Size GetScaleValue(const nsIFrame* aFrame) const; // Uncompute this AnimationValue and then serialize it. @@ -116,16 +115,6 @@ struct AnimationValue AppendTransformFunction(nsCSSKeyword aTransformFunction, nsCSSValueList**& aListTail); - // mGecko and mServo are mutually exclusive: only one or the other should - // ever be set. - // FIXME: After obsoleting StyleAnimationValue, we should remove mGecko, and - // make AnimationValue a wrapper of RawServoAnimationValue to hide these - // FFIs. - // Ideally we would use conditional compilation based on MOZ_OLD_STYLE in the - // Servo code that wants to initialize mGecko, but that seems tricky. So for - // now, just define a dummy member variable that its initialization code will - // work on, even when the old style system is compiled out. - uintptr_t mGecko; RefPtr mServo; };