Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-22 09:45:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1152517 - Recipient autocomplete wrongly considers last mouse-hovered contact from results dropdown "selected" and then uses that unintended, random recipient upon blur (via Tab, Enter, or when moving to subject or body). r=mak

Browse Source 
--HG--
extra : rebase_source : 8b11a0a5d6b9a41fbe3102ff17f83f452d1601b9
This commit is contained in:
Magnus Melin 2015-07-15 16:22:54 +03:00
parent ee6b010108
commit 422a1bbf1d
1 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
toolkit/content/widgets/autocomplete.xml
View File

@ -608,8 +608,27 @@
<handler event="blur" phase="capturing"><![CDATA[
if (!this._dontBlur) {
if (this.forceComplete && this.mController.matchCount >= 1)
if (this.forceComplete && this.mController.matchCount >= 1) {
// mousemove sets selected index. Don't blindly use that selected
// index in this blur handler since if the popup is open you can
// easily "select" another match just by moving the mouse over it.
let filledVal = this.value.replace(/.+ >> /, "").toLowerCase();
let selectedVal = null;
if (this.popup.selectedIndex >= 0) {
selectedVal = this.mController.getFinalCompleteValueAt(
this.popup.selectedIndex);
}
if (selectedVal && filledVal != selectedVal.toLowerCase()) {
for (let i = 0; i < this.mController.matchCount; i++) {
let matchVal = this.mController.getFinalCompleteValueAt(i);
if (matchVal.toLowerCase() == filledVal) {
this.popup.selectedIndex = i;
break;
}
}
}
this.mController.handleEnter(false);
}
this.detachController();
}
]]></handler>