Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-23 02:05:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1577783 - Use inspectorFront's getNodeFrontFromNodeGrip function in WebConsole's openNodeInInspector. r=pbro,rcaliman.

Browse Source 
We retrieve the right NodeFront from a given grip, which we
can then tell the inspector panel to select.

Differential Revision: https://phabricator.services.mozilla.com/D48810

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Nicolas Chevobbe 2019-10-18 09:07:42 +00:00
parent ca1e2e0939
commit 431636d12a
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
devtools/client/webconsole/webconsole.js
View File

@ -437,17 +437,18 @@ class WebConsole {
"inspector", "inspector",
"inspect_dom" "inspect_dom"
); );
// TODO: Bug1574506 - Use the contextual WalkerFront for gripToNodeFront.
const walkerFront = (await this.toolbox.target.getFront("inspector")) const onNodeFront = this.toolbox.target
.walker; .getFront("inspector")
const onGripNodeToFront = walkerFront.gripToNodeFront(grip); .then(inspectorFront => inspectorFront.getNodeFrontFromNodeGrip(grip));
const [front, inspector] = await Promise.all([
onGripNodeToFront, const [nodeFront, inspectorPanel] = await Promise.all([
onNodeFront,
onSelectInspector, onSelectInspector,
]); ]);
const onInspectorUpdated = inspector.once("inspector-updated"); const onInspectorUpdated = inspectorPanel.once("inspector-updated");
const onNodeFrontSet = this.toolbox.selection.setNodeFront(front, { const onNodeFrontSet = this.toolbox.selection.setNodeFront(nodeFront, {
reason: "console", reason: "console",
}); });