Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-24 10:45:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 523915 - updater crashes when trying to update with crash reporter open. r=ted.mielczarek

Browse Source
This commit is contained in:
Robert Strong 2009-11-13 13:11:32 -08:00
parent c7b10b17ed
commit 43c9508385
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
toolkit/mozapps/update/src/updater/updater.cpp
View File

@ -502,12 +502,16 @@ static FILE* ensure_open(const NS_tchar *path, const NS_tchar* flags, unsigned i
ensure_write_permissions(path);
FILE* f = NS_tfopen(path, flags);
if (NS_tchmod(path, options) != 0) {
fclose(f);
if (f != NULL) {
fclose(f);
}
return NULL;
}
struct stat ss;
if (NS_tstat(path, &ss) != 0 || ss.st_mode != options) {
fclose(f);
if (f != NULL) {
fclose(f);
}
return NULL;
}
return f;
@ -599,12 +603,15 @@ static int backup_restore(const NS_tchar *path)
NS_tsnprintf(backup, sizeof(backup), NS_T("%s" BACKUP_EXT), path);
int rv = copy_file(backup, path);
if (rv)
if (rv) {
ensure_remove(backup);
return rv;
}
rv = ensure_remove(backup);
if (rv)
if (rv) {
return WRITE_ERROR;
}
return OK;
}