Bug 1643817: Use a fresh taskgroup for create-interactive tasks; r=Callek

In Bug 1641971 (e7d4c490c31a) we changed `taskgraph.create.create_tasks` to
always get the decision task id to use. However, the call in create-interactive
passed `None`, expecting to have on generated. This changes that to use the
`create-interactive`s action task as the task id.

Differential Revision: https://phabricator.services.mozilla.com/D82652
This commit is contained in:
Tom Prince 2020-07-08 18:41:17 +00:00
parent fc3ae614bc
commit 440eed985f
2 changed files with 4 additions and 2 deletions

View File

@ -7,6 +7,7 @@
from __future__ import absolute_import, print_function, unicode_literals
import logging
import os
import re
import taskcluster_urls
@ -156,8 +157,9 @@ def create_interactive_action(parameters, graph_config, input, task_group_id, ta
# Create the task and any of its dependencies. This uses a new taskGroupId to avoid
# polluting the existing taskGroup with interactive tasks.
action_task_id = os.environ.get('TASK_ID')
label_to_taskid = create_tasks(graph_config, [label], full_task_graph, label_to_taskid,
parameters, modifier=edit)
parameters, decision_task_id=action_task_id, modifier=edit)
taskId = label_to_taskid[label]
logger.info('Created interactive task {}; sending notification'.format(taskId))

View File

@ -241,7 +241,7 @@ def update_dependencies(task, graph):
def create_tasks(graph_config, to_run, full_task_graph, label_to_taskid,
params, decision_task_id=None, suffix='', modifier=lambda t: t):
params, decision_task_id, suffix='', modifier=lambda t: t):
"""Create new tasks. The task definition will have {relative-datestamp':
'..'} rendered just like in a decision task. Action callbacks should use
this function to create new tasks,