Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-20 00:35:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1661897 - Acknowledge pending visual scroll updates for any RSF. r=botond

Browse Source 
We set pending visual scroll updates even for RSFs that are on subdocuments,
so we should ensure they get acknowledged and cleared on paints. Otherwise
the pending visual scroll update can get "stuck" and it affects things that
depend on it, such as the drag-selection code.

Differential Revision: https://phabricator.services.mozilla.com/D88893
This commit is contained in:
Kartikaya Gupta 2020-08-31 20:34:34 +00:00
parent 70acdd65af
commit 447dd12c94
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
layout/base/nsLayoutUtils.cpp
View File

@ -9296,7 +9296,9 @@ ScrollMetadata nsLayoutUtils::ComputeScrollMetadata(
presShell->ScrollToVisual(presShell->GetVisualViewportOffset(),
FrameMetrics::eRestore, ScrollMode::Instant);
}
}
if (scrollableFrame->IsRootScrollFrameOfDocument()) {
if (const Maybe<PresShell::VisualScrollUpdate>& visualUpdate =
presShell->GetPendingVisualScrollUpdate()) {
metrics.SetVisualDestination(
@ -9304,6 +9306,9 @@ ScrollMetadata nsLayoutUtils::ComputeScrollMetadata(
metrics.SetVisualScrollUpdateType(visualUpdate->mUpdateType);
presShell->AcknowledgePendingVisualScrollUpdate();
}
}
if (aIsRootContent) {
// Expand the layout viewport to the size including the area covered by
// the dynamic toolbar in the case where the dynamic toolbar is being
// used, otherwise when the dynamic toolbar transitions on the compositor,