Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-10 03:45:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 983293 - Part 5: Remove unecessary default settings in TextTrack ctors. r=cpearce

Browse Source 
Since there is no default constructor for TextTrack we don't
need to be setting mKind, mMode, or mReadyState to a default
value.
This commit is contained in:
Rick Eyre 2014-03-13 14:58:08 -04:00
parent ce47d2cbba
commit 45c8607a2d
1 changed files with 10 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
content/media/TextTrack.cpp
View File

@ -37,14 +37,14 @@ TextTrack::TextTrack(nsISupports* aParent,
TextTrackReadyState aReadyState,
TextTrackSource aTextTrackSource)
: mParent(aParent)
, mKind(aKind)
, mLabel(aLabel)
, mLanguage(aLanguage)
, mMode(aMode)
, mReadyState(aReadyState)
, mTextTrackSource(aTextTrackSource)
{
SetDefaultSettings();
mKind = aKind;
mLabel = aLabel;
mLanguage = aLanguage;
mMode = aMode;
mReadyState = aReadyState;
SetIsDOMBinding();
}
@ -58,27 +58,24 @@ TextTrack::TextTrack(nsISupports* aParent,
TextTrackSource aTextTrackSource)
: mParent(aParent)
, mTextTrackList(aTextTrackList)
, mKind(aKind)
, mLabel(aLabel)
, mLanguage(aLanguage)
, mMode(aMode)
, mReadyState(aReadyState)
, mTextTrackSource(aTextTrackSource)
{
SetDefaultSettings();
mKind = aKind;
mLabel = aLabel;
mLanguage = aLanguage;
mMode = aMode;
mReadyState = aReadyState;
SetIsDOMBinding();
}
void
TextTrack::SetDefaultSettings()
{
mKind = TextTrackKind::Subtitles;
mMode = TextTrackMode::Hidden;
mCueList = new TextTrackCueList(mParent);
mActiveCueList = new TextTrackCueList(mParent);
mCuePos = 0;
mDirty = false;
mReadyState = TextTrackReadyState::NotLoaded;
}
JSObject*