Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-20 00:35:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1528683 - Update and annotate existing QuantumBar TODO comments with bug numbers. r=mak

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D24199

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Mark Banner 2019-03-20 16:12:35 +00:00
parent ee898e0e37
commit 45e4b14a1a
4 changed files with 12 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
browser/components/urlbar/UrlbarEventBufferer.jsm
View File

@ -163,9 +163,9 @@ class UrlbarEventBufferer {
* the event.
*/
deferEvent(event, callback) {
// TODO: once one-off buttons are implemented, figure out if the following
// is true for the quantum bar as well: somehow event.defaultPrevented ends
// up true for deferred events. Autocomplete ignores defaultPrevented
// TODO Bug 1536822: once one-off buttons are implemented, figure out if the
// following is true for the quantum bar as well: somehow event.defaultPrevented
// ends up true for deferred events. Autocomplete ignores defaultPrevented
// events, which means it would ignore replayed deferred events if we didn't
// tell it to bypass defaultPrevented through urlbarDeferred.
// Check we don't try to defer events more than once.
@ -311,8 +311,8 @@ class UrlbarEventBufferer {
}
get lastResultIsSelected() {
// TODO: Once one-off buttons are fully implemented, it would be nice to have
// a better way to check if the next down will focus one-off buttons.
// TODO Bug 1536818: Once one-off buttons are fully implemented, it would be
// nice to have a better way to check if the next down will focus one-off buttons.
let results = this._lastQuery.results;
return results.length &&
results[results.length - 1] == this.input.view.selectedResult;

4
browser/components/urlbar/UrlbarInput.jsm
View File

@ -258,7 +258,7 @@ class UrlbarInput {
/**
* Handles an event which would cause a url or text to be opened.
* XXX the name is currently handleCommand which is compatible with
* TODO Bug 1536816 the name is currently handleCommand which is compatible with
* urlbarBindings. However, it is no longer called automatically by autocomplete,
* See _on_keydown.
*
@ -1238,7 +1238,7 @@ class UrlbarInput {
let allowAutofill =
this._maybeAutofillOnInput(value, deletedAutofilledSubstring);
// XXX Fill in lastKey, and add anything else we need.
// TODO Bug 1524550: Fill in lastKey, and add anything else we need.
this.startQuery({
searchString: value,
allowAutofill,

4
browser/components/urlbar/tests/UrlbarTestUtils.jsm
View File

@ -354,7 +354,7 @@ class UrlbarAbstraction {
await new Promise(resolve => this.window.requestIdleCallback(resolve, {timeout: 1000}));
return this.panel.richlistbox.itemChildren[index];
}
// TODO: Quantum Bar doesn't yet implement lazy results replacement.
// TODO Bug 1530338: Quantum Bar doesn't yet implement lazy results replacement.
await this.promiseSearchComplete();
if (index >= this.urlbar.view._rows.length) {
throw new Error("Not enough results");
@ -502,7 +502,7 @@ class UrlbarAbstraction {
return false;
}, "Waiting for suggestions");
}
// TODO: Quantum Bar doesn't yet implement lazy results replacement. When
// TODO Bug 1530338: Quantum Bar doesn't yet implement lazy results replacement. When
// we do that, we'll have to be sure the suggestions we find are relevant
// for the current query. For now let's just wait for the search to be
// complete.

8
browser/components/urlbar/tests/legacy/browser.ini
View File

@ -6,11 +6,9 @@ support-files =
../browser/head-common.js
head.js
# XXX Bug 1514162: These are tests that have not yet been ported to the new
# QuantumBar.
#
# If you port a test, please move it to the section below to make it clearer
# to identify the remaining tests.
# These tests are ones we are not porting to QuantumBar. The ones in the
# section underneath this are ones that work in both QuantumBar and the legacy
# address bar.
# Not porting browser_switchtab_override_keynav.js/browser_switchtab_copy.js
# to QuantumBar as we no longer have moz-action uris, so they aren't relevant