Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-11 04:15:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

checking in patch from Jon Smirl <jonsmirl@mediaone.net> that lets us see past xptcall 'SharedStub' frames in stack traces. Because xptcall was doing a non-standard frame the debuggers and trace tools were not showing callers. This fixes that problem and will allow us to get *much* better data on crashes and other problems where the stack crosses xptcall. Tested on debug and release. r=jband@netscape.com, a=brendan@mozilla.org, a=waterson@mozilla.org. Thank you Jon!

Browse Source
This commit is contained in:
jband%netscape.com 2000-09-22 10:09:23 +00:00
parent 0211361dad
commit 45e7f2d67e
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
xpcom/reflect/xptcall/src/md/win32/xptcstubs.cpp
View File

@ -115,16 +115,15 @@ static __declspec(naked) void SharedStub(void)
push ecx // make room for a ptr
lea eax, [ebp-4] // pointer to stackBytesToPop
push eax
lea ecx, [ebp+16] // pointer to args
push ecx
mov edx, [ebp+4] // vtbl_index
push edx
mov eax, [ebp+12] // this
lea eax, [ebp+12] // pointer to args
push eax
push ecx // vtbl_index
mov eax, [ebp+8] // this
push eax
call PrepareAndDispatch
mov edx, [ebp+8] // return address
mov edx, [ebp+4] // return address
mov ecx, [ebp-4] // stackBytesToPop
add ecx, 12 // for this, the index, and ret address
add ecx, 8 // for 'this' and return address
mov esp, ebp
pop ebp
add esp, ecx // fix up stack pointer
@ -135,7 +134,7 @@ static __declspec(naked) void SharedStub(void)
// these macros get expanded (many times) in the file #included below
#define STUB_ENTRY(n) \
__declspec(naked) nsresult __stdcall nsXPTCStubBase::Stub##n() \
{ __asm push n __asm jmp SharedStub }
{ __asm mov ecx, n __asm jmp SharedStub }
#define SENTINEL_ENTRY(n) \
nsresult __stdcall nsXPTCStubBase::Sentinel##n() \