Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-19 00:05:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1207245 - part 6a - call AddRef/Release from nsRefPtr itself, rather than a helper; r=me

Browse Source
This commit is contained in:
Nathan Froyd 2015-10-07 15:32:51 -04:00
parent 8bbfcaea75
commit 45f70b7f95
1 changed files with 20 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
mfbt/nsRefPtr.h
View File

@ -346,24 +346,40 @@ private:
// This should be sound because while |nsRefPtr<const T>| provides a
// const view of an object, the object itself should not be const (it
// would have to be allocated as |new const T| or similar to be const).
// Because some classes make their AddRef/Release implementations private
// and then friend RefPtr to make them visible, we redirect AddRefTraits's
// calls to static helper functions in RefPtr so we don't have to figure
// out how to make AddRefTraits visible to *those* classes.
static MOZ_ALWAYS_INLINE void
AddRefTraitsAddRefHelper(typename mozilla::RemoveConst<T>::Type* aPtr)
{
aPtr->AddRef();
}
static MOZ_ALWAYS_INLINE void
AddRefTraitsReleaseHelper(typename mozilla::RemoveConst<T>::Type* aPtr)
{
aPtr->Release();
}
template<class U>
struct AddRefTraits
{
static void AddRef(U* aPtr) {
aPtr->AddRef();
RefPtr<T>::AddRefTraitsAddRefHelper(aPtr);
}
static void Release(U* aPtr) {
aPtr->Release();
RefPtr<T>::AddRefTraitsReleaseHelper(aPtr);
}
};
template<class U>
struct AddRefTraits<const U>
{
static void AddRef(const U* aPtr) {
const_cast<U*>(aPtr)->AddRef();
RefPtr<T>::AddRefTraitsAddRefHelper(const_cast<U*>(aPtr));
}
static void Release(const U* aPtr) {
const_cast<U*>(aPtr)->Release();
RefPtr<T>::AddRefTraitsReleaseHelper(const_cast<U*>(aPtr));
}
};
};