mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-10 11:55:49 +00:00
Bugzilla Bug 298409: fixed an array index off-by-one error and a memory
leak. r=nelsonb.
This commit is contained in:
parent
efdb7c74c9
commit
47bf55ca0f
@ -1367,7 +1367,7 @@ crlgen_setNextDataFn_extension(CRLGENGeneratorData *crlGenData, void *str,
|
|||||||
return SECFailure;
|
return SECFailure;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
if (extStr->nextUpdatedData > MAX_EXT_DATA_LENGTH) {
|
if (extStr->nextUpdatedData >= MAX_EXT_DATA_LENGTH) {
|
||||||
PORT_SetError(SEC_ERROR_INVALID_ARGS);
|
PORT_SetError(SEC_ERROR_INVALID_ARGS);
|
||||||
crlgen_PrintError(crlGenData->parsedLineNum,
|
crlgen_PrintError(crlGenData->parsedLineNum,
|
||||||
"number of fields in extension "
|
"number of fields in extension "
|
||||||
@ -1415,7 +1415,7 @@ crlgen_destroyTempData(CRLGENGeneratorData *crlGenData)
|
|||||||
PORT_Free(crlGenData->certEntry);
|
PORT_Free(crlGenData->certEntry);
|
||||||
break;
|
break;
|
||||||
case CRLGEN_ADD_EXTENSION_CONTEXT:
|
case CRLGEN_ADD_EXTENSION_CONTEXT:
|
||||||
if (crlGenData->extensionEntry->nextUpdatedData) {
|
if (crlGenData->extensionEntry->extData) {
|
||||||
int i = 0;
|
int i = 0;
|
||||||
for (;i < crlGenData->extensionEntry->nextUpdatedData;i++)
|
for (;i < crlGenData->extensionEntry->nextUpdatedData;i++)
|
||||||
PORT_Free(*(crlGenData->extensionEntry->extData + i));
|
PORT_Free(*(crlGenData->extensionEntry->extData + i));
|
||||||
|
Loading…
Reference in New Issue
Block a user