Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-01 00:32:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1665355 - Don't throw on appcache.update() if the storage is disabled r=baku

Browse Source 
To avoid applications breaking, this method shouldn't throw when called if the
pref is set to off.

To reproduce go to: https://webdbg.com/test/appcache/
Open devtools console
Type: appCache.update()
Make sure it doesn't throw

Differential Revision: https://phabricator.services.mozilla.com/D90390
This commit is contained in:
Valentin Gosu 2020-09-18 13:57:11 +00:00
parent e45fb60afb
commit 486de00f22
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
dom/offline/nsDOMOfflineResourceList.cpp
View File

@ -26,6 +26,7 @@
#include "mozilla/EventDispatcher.h"
#include "mozilla/Preferences.h"
#include "mozilla/BasePrincipal.h"
#include "mozilla/StaticPrefs_browser.h"
#include "nsXULAppAPI.h"
#define IS_CHILD_PROCESS() (GeckoProcessType_Default != XRE_GetProcessType())
@ -486,6 +487,11 @@ void nsDOMOfflineResourceList::Update(ErrorResult& aRv) {
return;
}
// If the storage is disabled this operation should be ignored.
if (!StaticPrefs::browser_cache_offline_storage_enable()) {
return;
}
if (!nsContentUtils::OfflineAppAllowed(mDocumentURI)) {
aRv.Throw(NS_ERROR_DOM_SECURITY_ERR);
return;