Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-22 01:35:35 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1634253 - P5. Make threading model clearer. r=kats

Browse Source 
CompositorBridgeParent::ScheduleTask was always called from the compositor thread ; so make it explicit that we are dispatching the task to the compositor thread.

We inline the method instead.

Differential Revision: https://phabricator.services.mozilla.com/D73824
This commit is contained in:
Jean-Yves Avenard 2020-05-08 20:20:25 +00:00
parent 4f02149e61
commit 48971d875b
2 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
gfx/layers/ipc/CompositorBridgeParent.cpp
View File

@ -833,15 +833,6 @@ bool CompositorBridgeParent::ScheduleResumeOnCompositorThread(int x, int y,
return !mPaused;
}
void CompositorBridgeParent::ScheduleTask(
already_AddRefed<CancelableRunnable> task, int time) {
if (time == 0) {
MessageLoop::current()->PostTask(std::move(task));
} else {
MessageLoop::current()->PostDelayedTask(std::move(task), time);
}
}
void CompositorBridgeParent::UpdatePaintTime(LayerTransactionParent* aLayerTree,
const TimeDuration& aPaintTime) {
// We get a lot of paint timings for things with empty transactions.
@ -1234,7 +1225,12 @@ void CompositorBridgeParent::ScheduleRotationOnCompositorThread(
"layers::CompositorBridgeParent::ForceComposition", this,
&CompositorBridgeParent::ForceComposition);
mForceCompositionTask = task;
ScheduleTask(task.forget(), StaticPrefs::layers_orientation_sync_timeout());
if (StaticPrefs::layers_orientation_sync_timeout() == 0) {
CompositorThreadHolder::Loop()->PostTask(task.forget());
} else {
CompositorThreadHolder::Loop()->PostDelayedTask(
task.forget(), StaticPrefs::layers_orientation_sync_timeout());
}
}
}

1
gfx/layers/ipc/CompositorBridgeParent.h
View File

@ -750,7 +750,6 @@ class CompositorBridgeParent final : public CompositorBridgeParentBase,
const LayersId& aId) override;
bool DeallocPLayerTransactionParent(
PLayerTransactionParent* aLayers) override;
virtual void ScheduleTask(already_AddRefed<CancelableRunnable>, int);
void SetEGLSurfaceRect(int x, int y, int width, int height);