Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-10 11:55:49 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix for bug #392099: unable to search for downloads with % (SQLite MATCH_ALL) or _ (SQLite MATCH_ONE) in the name r=sdwilsh

Browse Source
This commit is contained in:
sspitzer@mozilla.org 2007-08-14 07:04:27 -07:00
parent 34508ed9e8
commit 49837e3197
1 changed files with 6 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
toolkit/mozapps/downloads/content/downloads.js
View File

@ -742,29 +742,19 @@ function buildDownloadListWithSearch(aTerms)
buildDefaultView();
return;
}
var terms = aTerms.split(" ");
if (terms.length == 0)
return;
var sql = "SELECT id, target, name, source, state, startTime " +
"FROM moz_downloads ";
for (var i = 0; i < terms.length; i++) {
if (terms[i] == "") continue;
sql += i == 0 ? "WHERE " : "OR ";
// We cannot actually bind parameter because it will not pick up the
// parameter if we give it '%?1%', and we can't add spaces :(
sql += "name LIKE '%" + terms[i] + "%' ";
}
sql += "AND state != ?1 " +
"AND state != ?2 " +
"ORDER BY endTime ASC";
"FROM moz_downloads WHERE name LIKE ?1 ESCAPE '/' " +
"AND state != ?2 AND state != ?3 ORDER BY endTime ASC";
var db = gDownloadManager.DBConnection;
var stmt = db.createStatement(sql);
try {
stmt.bindInt32Parameter(0, Ci.nsIDownloadManager.DOWNLOAD_DOWNLOADING);
stmt.bindInt32Parameter(1, Ci.nsIDownloadManager.DOWNLOAD_PAUSED);
var paramForLike = stmt.escapeStringForLIKE(aTerms, '/');
stmt.bindStringParameter(0, "%" + paramForLike + "%");
stmt.bindInt32Parameter(1, Ci.nsIDownloadManager.DOWNLOAD_DOWNLOADING);
stmt.bindInt32Parameter(2, Ci.nsIDownloadManager.DOWNLOAD_PAUSED);
buildDownloadList(stmt, gDownloadsOtherTitle);
} finally {
stmt.reset();