Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-04-02 20:42:49 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 347952. Don't do expensive WidgetToScreen translations when positioning zero-sized popups. r+sr=bzbarsky

Browse Source
This commit is contained in:
roc+%cs.cmu.edu 2006-08-16 01:54:30 +00:00
parent 9ab0dd3905
commit 4a4a22c9a0
1 changed files with 15 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
view/src/nsView.cpp
View File

@ -352,6 +352,20 @@ void nsView::DoResetWidgetBounds(PRBool aMoveOnly,
if (mViewManager->GetRootView() == this) {
return;
}
nsRect curBounds;
mWindow->GetBounds(curBounds);
nsWindowType type;
mWindow->GetWindowType(type);
if (curBounds.IsEmpty() && mDimBounds.IsEmpty() && type == eWindowType_popup) {
// Don't manipulate empty popup widgets. For example there's no point
// moving hidden comboboxes around, or doing X server roundtrips
// to compute their true screen position. This could mean that WidgetToScreen
// operations on these widgets don't return up-to-date values, but popup
// positions aren't reliable anyway because of correction to be on or off-screen.
return;
}
NS_PRECONDITION(mWindow, "Why was this called??");
nsIDeviceContext *dx;
@ -365,9 +379,7 @@ void nsView::DoResetWidgetBounds(PRBool aMoveOnly,
nsPoint offset(0, 0);
if (GetParent()) {
nsIWidget* parentWidget = GetParent()->GetNearestWidget(&offset);
nsWindowType type;
mWindow->GetWindowType(type);
if (type == eWindowType_popup) {
// put offset into screen coordinates
nsRect screenRect(0,0,1,1);
@ -387,8 +399,6 @@ void nsView::DoResetWidgetBounds(PRBool aMoveOnly,
if (!(mVFlags & NS_VIEW_FLAG_HAS_POSITIONED_WIDGET)) {
mVFlags |= NS_VIEW_FLAG_HAS_POSITIONED_WIDGET;
} else {
nsRect curBounds;
mWindow->GetBounds(curBounds);
changedPos = curBounds.TopLeft() != newBounds.TopLeft();
changedSize = curBounds.Size() != newBounds.Size();
}