Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-10 20:05:49 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 180169 ASSERTION: RgnRectMemoryAllocator not thread-safe triggers because static class exists past nspr shutdown

Browse Source 
r=roc+moz sr=roc+moz
This commit is contained in:
timeless%mozdev.org 2003-05-23 21:42:36 +00:00
parent af2d8d7225
commit 4a9cdfd6ec
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
gfx/src/nsRegion.cpp
View File

@ -106,7 +106,21 @@ RgnRectMemoryAllocator::~RgnRectMemoryAllocator ()
FreeChunk (tmp);
}
#if 0
/*
* As a static object this class outlives any library which would implement
* locking. So we intentionally leak the 'lock'.
*
* Currently RgnRectMemoryAllocator is only used from the primary thread,
* so we aren't using a lock which means that there is no lock to leak.
* If we ever switch to multiple GUI threads (e.g. one per window),
* we'd probably use one allocator per window-thread to avoid the
* locking overhead and just require consumers not to pass regions
* across threads/windows, which would be a reasonable restriction
* because they wouldn't be useful outside their window.
*/
DestroyLock();
#endif
}
nsRegion::RgnRect* RgnRectMemoryAllocator::Alloc ()