Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-26 14:22:01 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1565396 - Annotate use of memcpy instead of memcpySafeWhenRacy in WebGLBuffer. r=hsivonen

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D37802

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Jeff Gilbert 2019-08-05 06:26:56 +00:00
parent 0baa66f01b
commit 4aefa55c19
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
dom/canvas/WebGLBuffer.cpp
View File

@ -105,6 +105,12 @@ void WebGLBuffer::BufferData(GLenum target, uint64_t size, const void* data,
mContext->ErrorOutOfMemory("Failed to alloc index cache."); mContext->ErrorOutOfMemory("Failed to alloc index cache.");
return; return;
} }
// memcpy out of SharedArrayBuffers can be racey, and should generally use
// memcpySafeWhenRacy. But it's safe here:
// * We only memcpy in one place.
// * We only read out of the single copy, and only after copying.
// * If we get data value corruption from racing read-during-write, that's
// fine.
memcpy(newIndexCache.get(), data, size); memcpy(newIndexCache.get(), data, size);
uploadData = newIndexCache.get(); uploadData = newIndexCache.get();
} }