Bug 1330791 - Enable the no-native-reassign rule for eslint in /services and fix the associated error. r=markh

MozReview-Commit-ID: 65EsZGCJPMD

--HG--
extra : rebase_source : 716697450e8506240a50a29508bf4943c37f48ef

services/.eslintrc.js

@@ -10,7 +10,6 @@ module.exports = {
        respective line in this file should be removed. */
     "consistent-return": "warn",
     "no-func-assign": "warn",
-    "no-native-reassign": "warn",
     "no-nested-ternary": "warn",
   }
 };

services/sync/tests/unit/test_status.js

@@ -73,7 +73,7 @@ function run_test() {
 
   do_check_eq(Status.service, STATUS_OK);
   do_check_eq(Status.sync, SYNC_SUCCEEDED);
-  for (name in Status.engines) {
+  if (Status.engines.length) {
     do_throw("Status.engines should be empty.");
   }