Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-20 00:35:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1481084 - Assertion OnSocketThread() in HttpBackgroundChannelChild::RecvOnStopRequest during shutdown r=dragana

Browse Source 
OnSocketTread doesn't work properly during shutdown because nsSocketTransportService2.cpp::gSocketThread is null.
We call gSocketTransportService->IsOnCurrentThreadInfallible() instead, just like we already do in HttpBackgroundChannelChild::ActorDestroy()

Differential Revision: https://phabricator.services.mozilla.com/D5050

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Valentin Gosu 2018-09-06 21:03:10 +00:00
parent 723d009804
commit 4c346828a4
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
netwerk/protocol/http/HttpBackgroundChannelChild.cpp
View File

@ -181,7 +181,8 @@ HttpBackgroundChannelChild::RecvOnStopRequest(
const nsHttpHeaderArray& aResponseTrailers)
{
LOG(("HttpBackgroundChannelChild::RecvOnStopRequest [this=%p]\n", this));
MOZ_ASSERT(OnSocketThread());
MOZ_ASSERT(gSocketTransportService);
MOZ_ASSERT(gSocketTransportService->IsOnCurrentThreadInfallible());
// It's enough to set this from (just before) OnStopRequest notification, since
// we don't need this value sooner than a channel was done loading - everything