Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-25 22:01:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1488503: Add test for validation. r=jdescottes

Browse Source 
Depends on D23993

Differential Revision: https://phabricator.services.mozilla.com/D23994

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Daisuke Akatsuka 2019-03-21 08:26:59 +00:00
parent 6bfbee8394
commit 4c8a6b7b69
2 changed files with 17 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
devtools/client/aboutdebugging-new/src/components/connect/NetworkLocationsForm.js
View File

@ -73,7 +73,8 @@ class NetworkLocationsForm extends PureComponent {
return Message(
{
className: "connect-page__network-form__error-message",
className: "connect-page__network-form__error-message " +
"qa-connect-page__network-form__error-message",
level: MESSAGE_LEVEL.ERROR,
},
Localized(

18
devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_connect_networklocations.js
View File

@ -9,6 +9,7 @@
*/
const TEST_NETWORK_LOCATION = "localhost:1111";
const TEST_NETWORK_LOCATION_INVALID = "testnetwork";
add_task(async function() {
const { document, tab } = await openAboutDebugging();
@ -18,20 +19,30 @@ add_task(async function() {
let networkLocations = document.querySelectorAll(".js-network-location");
is(networkLocations.length, 0, "By default, no network locations are displayed");
addNetworkLocation(TEST_NETWORK_LOCATION, document);
info("Check whether error message should show if the input value is invalid");
addNetworkLocation(TEST_NETWORK_LOCATION_INVALID, document);
await waitUntil(() =>
document.querySelector(".qa-connect-page__network-form__error-message"));
info("Wait until the new network location is visible in the list");
addNetworkLocation(TEST_NETWORK_LOCATION, document);
await waitUntil(() => document.querySelectorAll(".js-network-location").length === 1);
networkLocations = document.querySelectorAll(".js-network-location");
await waitUntil(() =>
!document.querySelector(".qa-connect-page__network-form__error-message"));
networkLocations = document.querySelectorAll(".js-network-location");
const networkLocationValue =
networkLocations[0].querySelector(".js-network-location-value");
is(networkLocationValue.textContent, TEST_NETWORK_LOCATION,
"Added network location has the expected value");
removeNetworkLocation(TEST_NETWORK_LOCATION, document);
info("Check whether error message should show if the input value was duplicate");
addNetworkLocation(TEST_NETWORK_LOCATION, document);
await waitUntil(() =>
document.querySelector(".qa-connect-page__network-form__error-message"));
info("Wait until the new network location is removed from the list");
removeNetworkLocation(TEST_NETWORK_LOCATION, document);
await waitUntil(() => document.querySelectorAll(".js-network-location").length === 0);
await removeTab(tab);
@ -41,6 +52,7 @@ function addNetworkLocation(location, document) {
info("Setting a value in the network form input");
const networkLocationInput =
document.querySelector(".js-network-form-input");
networkLocationInput.value = "";
networkLocationInput.focus();
EventUtils.sendString(location, networkLocationInput.ownerGlobal);