Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-18 15:55:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1280184 - Turn off downloads integration on Android M and later. r=snorp

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D5948

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Jan Henning 2018-09-17 15:01:03 +00:00
parent 50690041b2
commit 4d3821f569
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
mobile/android/base/java/org/mozilla/gecko/DownloadsIntegration.java
View File

@ -106,6 +106,27 @@ public class DownloadsIntegration implements BundleEventListener
return false;
}
if (Versions.feature23Plus) {
// Bug 1280184:
// Starting from Android M, the system download manager has started to delete downloaded
// files if the download is removed from the download manager again or if the down-
// loading app is subsequently uninstalled, even if the files have been downloaded to a
// public folder on the shared storage.
// In Android O, this was changed to only clean up files in app-private directories and
// leave files e.g. in the public Downloads folder alone, but that fix only applies to
// files actually downloaded via the download manager. Files that are registered with
// the download manager after having been downloaded independently, as in our case, are
// still deleted unconditionally when the registering app is uninstalled.
// Additionally, starting from Android O Google has also started replacing the former
// user-facing part of the download manager, the Downloads app, with a new general file
// explorer-type app, whose "Downloads" view simply shows all files stored in the
// corresponding folder.
// Since that removes the only raison d'être of the downloads integration and we also
// don't want to delete user's downloads just because they're uninstalling us, we dis-
// able downloads integration again on all Android versions exhibiting this behaviour.
return false;
}
int state = PackageManager.COMPONENT_ENABLED_STATE_DEFAULT;
try {
final PackageManager pm = GeckoAppShell.getApplicationContext()