Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-09 03:15:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1677822 - Capture last line in the YSOD telemetry. r=peterv DONTBUILD

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D97348
This commit is contained in:
Zibi Braniecki 2020-11-18 20:29:41 +00:00
parent 921110e00f
commit 4db97d1029
3 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
parser/htmlparser/nsExpatDriver.cpp
View File

@ -828,6 +828,10 @@ nsresult nsExpatDriver::HandleError() {
nsPrintfCString("%u", code)},
mozilla::Telemetry::EventExtraEntry{
"location"_ns, nsPrintfCString("%u:%u", lineNumber, colNumber)},
mozilla::Telemetry::EventExtraEntry{
"last_line"_ns, NS_ConvertUTF16toUTF8(mLastLine)},
mozilla::Telemetry::EventExtraEntry{
"last_line_len"_ns, nsPrintfCString("%u", mLastLine.Length())},
});
mozilla::Telemetry::SetEventRecordingEnabled("ysod"_ns, true);

7
parser/htmlparser/tests/mochitest/browser_ysod_telemetry.js
View File

@ -30,7 +30,12 @@ add_task(async function test_popup_opened() {
method: "shown",
object: "ysod",
value: PAGE_URL.substr(0, 80),
extra: { error_code: "11", location: "3:12" },
extra: {
error_code: "11",
location: "3:12",
last_line: " <title>&nonExistingEntity;</title>",
last_line_len: "38",
},
},
],
{

2
toolkit/components/telemetry/Events.yaml
View File

@ -2567,3 +2567,5 @@ ysod:
extra_keys:
error_code: Code of the XML Error (See `XML_Error` enum in expat.h for the list of errors where XML_ERROR_NONE is 0).
location: Location as Row:Column of where the error happened.
last_line: The content of the last line that led to the error.
last_line_len: The length of the last line that led to the error.