Bug 1850045: fix bustage introduced by taskgraph 6.2.1 update r=ahal,taskgraph-reviewers,releng-reviewers

This is only sortof a new issue - it's come up because we longer allow `group_by` functions to be overridden, and the taskgraph version of the `single` group doesn't handle the `only-for` blocks that we use all over the place.

This patch provides a quick fix -- renaming the Gecko `single` group-by to `single-with-filters`, and using that in most places. (There were a couple of places that switching to `with-attributes` was simple enough - but in many cases we cannot yet replicate this functionality with `from-deps` alone AFAIK.)

Differential Revision: https://phabricator.services.mozilla.com/D186821

taskcluster/ci/beetmover-apt/kind.yml

@@ -21,6 +21,7 @@ only-for-build-platforms:
 
 jobs:
     beetmover-apt:
-        from-deps: {}
+        from-deps:
+            group-by: single-with-filters
         run-on-releases:
             - nightly

taskcluster/ci/beetmover-checksums/kind.yml

@@ -19,7 +19,8 @@ only-for-attributes:
 
 jobs:
     beetmover-checksums:
-        from-deps: {}
+        from-deps:
+            group-by: single-with-filters
         shipping-phase: promote
         attributes:
             artifact_prefix: public

taskcluster/ci/beetmover-geckoview/kind.yml

@@ -38,7 +38,8 @@ not-for-build-platforms:
 
 jobs:
     beetmover-geckoview:
-        from-deps: {}
+        from-deps:
+            group-by: single-with-filters
         attributes:
             artifact_map: taskcluster/gecko_taskgraph/manifests/fennec_geckoview.yml
         run-on-projects: ['mozilla-release']

taskcluster/ci/beetmover-source/kind.yml

@@ -16,7 +16,8 @@ kind-dependencies:
 
 jobs:
     beetmover-source:
-        from-deps: {}
+        from-deps:
+            group-by: single-with-filters
         shipping-phase: promote
         attributes:
             artifact_map: taskcluster/gecko_taskgraph/manifests/source_files.yml

taskcluster/ci/build-mac-notarization/kind.yml

@@ -20,6 +20,7 @@ only-for-attributes:
 jobs:
     build-mac-notarization:
         from-deps:
+            group-by: single-with-filters
             copy-attributes: true
         treeherder:
             symbol: BMN

taskcluster/ci/build-mac-signing/kind.yml

@@ -25,7 +25,8 @@ only-for-build-platforms:
 
 jobs:
     build-mac-signing:
-        from-deps: {}
+        from-deps:
+            group-by: single-with-filters
         treeherder:
             symbol: BMS
         enable-signing-routes: false

taskcluster/ci/fxrecord/kind.yml

@@ -21,7 +21,8 @@ jobs:
     fxrecord:
         name: notify-fxrecord-failure
         description: "Desktop Startup Visual Metrics"
-        from-deps: {}
+        from-deps:
+            group-by: single-with-filters
         run-on-projects:
             - "mozilla-central"
         worker-type: performance-hardware/gecko-t-fxrecorder

taskcluster/ci/geckodriver-signing/kind.yml

@@ -13,9 +13,8 @@ transforms:
 kind-dependencies:
     - toolchain
 
-only-for-attributes:
-    - geckodriver
-
 jobs:
     geckodriver-signing:
-        from-deps: {}
+        from-deps:
+            with-attributes:
+                geckodriver: [true]

taskcluster/ci/mar-signing-autograph-stage/kind.yml

@@ -18,7 +18,8 @@ only-for-build-platforms:
 
 jobs:
     mar-signing-autograph-stage:
-        from-deps: {}
+        from-deps:
+            group-by: single-with-filters
         shipping-phase: null
         treeherder-group: ms-stage
         treeherder:

taskcluster/ci/mar-signing-l10n/kind.yml

@@ -30,7 +30,8 @@ only-for-build-platforms:
 
 jobs:
     mar-signing-l10n:
-        from-deps: {}
+        from-deps:
+            group-by: single-with-filters
         shipping-phase: promote
         treeherder-group: ms
         description-suffix: 'mar signing'

taskcluster/ci/mar-signing/kind.yml

@@ -31,7 +31,8 @@ only-for-build-platforms:
 
 jobs:
     mar-signing:
-        from-deps: {}
+        from-deps:
+            group-by: single-with-filters
         shipping-phase: promote
         treeherder-group: ms
         description-suffix: 'mar signing'

taskcluster/ci/partials-signing/kind.yml

@@ -15,7 +15,8 @@ kind-dependencies:
 
 jobs:
     partials-signing:
-        from-deps: {}
+        from-deps:
+            group-by: single-with-filters
         shipping-phase: promote
         treeherder-group: ps
         description-suffix: 'partial signing'

taskcluster/ci/partials/kind.yml

@@ -34,5 +34,6 @@ only-for-build-platforms:
 
 jobs:
     partials:
-        from-deps: {}
+        from-deps:
+            group-by: single-with-filters
         shipping-phase: promote

taskcluster/ci/release-beetmover-signed-langpacks-checksums/kind.yml

@@ -15,7 +15,8 @@ kind-dependencies:
 
 jobs:
     release-beetmover-signed-langpacks-checksums:
-        from-deps: {}
+        from-deps:
+            group-by: single-with-filters
         shipping-phase: promote
         attributes:
             artifact_prefix: public

taskcluster/ci/release-eme-free-repack-beetmover/kind.yml

@@ -20,7 +20,8 @@ only-for-build-platforms:
 
 jobs:
     release-eme-free-repack-beetmover:
-        from-deps: {}
+        from-deps:
+            group-by: single-with-filters
         shipping-phase: promote
         partner-bucket-scope:
             by-release-level:

taskcluster/ci/release-eme-free-repack-repackage-signing/kind.yml

@@ -20,4 +20,5 @@ only-for-build-platforms:
 
 jobs:
     release-eme-free-repack-repackage-signing:
-        from-deps: {}
+        from-deps:
+            group-by: single-with-filters

taskcluster/ci/release-eme-free-repack-repackage/kind.yml

@@ -26,7 +26,8 @@ only-for-build-platforms:
 
 jobs:
     release-eme-free-repack-repackage:
-        from-deps: {}
+        from-deps:
+            group-by: single-with-filters
         upstream-mac-kind:
             by-build-type:
                 debug: release-eme-free-repack-mac-signing

taskcluster/ci/release-partner-repack-beetmover/kind.yml

@@ -24,7 +24,8 @@ only-for-build-platforms:
 
 jobs:
     release-partner-repack-beetmover:
-        from-deps: {}
+        from-deps:
+            group-by: single-with-filters
         shipping-phase: promote
         partner-bucket-scope:
             by-release-level:

taskcluster/ci/release-partner-repack-repackage-signing/kind.yml

@@ -25,4 +25,5 @@ only-for-build-platforms:
 
 jobs:
     release-partner-repack-repackage-signing:
-        from-deps: {}
+        from-deps:
+            group-by: single-with-filters

taskcluster/ci/release-partner-repack-repackage/kind.yml

@@ -27,7 +27,8 @@ only-for-build-platforms:
 
 jobs:
     release-partner-repack-repackage:
-        from-deps: {}
+        from-deps:
+            group-by: single-with-filters
         upstream-mac-kind:
             by-build-type:
                 debug: release-partner-repack-mac-signing

taskcluster/ci/repackage-deb-l10n/kind.yml

@@ -23,7 +23,8 @@ only-for-build-platforms:
 
 jobs:
     repackage-deb-l10n:
-        from-deps: {}
+        from-deps:
+            group-by: single-with-filters
         worker-type: b-linux-gcp
         worker:
             docker-image: {"in-tree": "debian12-repackage"}

taskcluster/ci/repackage-deb/kind.yml

@@ -28,7 +28,8 @@ only-for-attributes:
 
 jobs:
     repackage-deb:
-        from-deps: {}
+        from-deps:
+            group-by: single-with-filters
         shipping-phase: promote
         worker-type: b-linux-gcp
         worker:

taskcluster/ci/repackage-l10n/kind.yml

@@ -35,7 +35,8 @@ only-for-build-platforms:
 
 jobs:
     repackage-l10n:
-        from-deps: {}
+        from-deps:
+            group-by: single-with-filters
         upstream-mac-kind:
             by-build-type:
                 debug: shippable-l10n-mac-signing

taskcluster/ci/repackage-msi/kind.yml

@@ -25,7 +25,8 @@ only-for-build-platforms:
 jobs:
     repackage-msi:
         worker-type: 'b-win2022'
-        from-deps: {}
+        from-deps:
+            group-by: single-with-filters
         mozharness:
             use-magic-mh-args: false
             config:

taskcluster/ci/repackage-signing-l10n/kind.yml

@@ -27,4 +27,5 @@ only-for-build-platforms:
 
 jobs:
     repackage-signing-l10n:
-        from-deps: {}
+        from-deps:
+            group-by: single-with-filters

taskcluster/ci/repackage-signing-msi/kind.yml

@@ -23,4 +23,5 @@ only-for-build-platforms:
 
 jobs:
     repackage-signing-msi:
-        from-deps: {}
+        from-deps:
+            group-by: single-with-filters

taskcluster/ci/repackage-signing-msix/kind.yml

@@ -15,4 +15,5 @@ kind-dependencies:
 
 jobs:
     repackage-signing-msix:
-        from-deps: {}
+        from-deps:
+            group-by: single-with-filters

taskcluster/ci/repackage-signing/kind.yml

@@ -25,4 +25,5 @@ only-for-build-platforms:
 
 jobs:
     repackage-signing:
-        from-deps: {}
+        from-deps:
+            group-by: single-with-filters

taskcluster/ci/repackage/kind.yml

@@ -43,7 +43,8 @@ only-for-build-platforms:
 
 jobs:
     repackage:
-        from-deps: {}
+        from-deps:
+            group-by: single-with-filters
         upstream-mac-kind:
             by-build-type:
                 debug: build-mac-signing

taskcluster/ci/upload-generated-sources-dummy/kind.yml

@@ -21,5 +21,6 @@ kind-dependencies:
 jobs:
     upload-generated-sources-dummy:
         description: Dummy task to pull in mac x64 and aarch64 upload-generated-symbols tasks
-        from-deps: {}
+        from-deps:
+            group-by: single-with-filters
         worker-type: succeed

taskcluster/ci/upload-symbols-dummy/kind.yml

@@ -22,5 +22,6 @@ jobs:
     upload-symbols-dummy:
         description: Dummy task to pull in mac x64 and aarch64 upload-symbols tasks
         from-deps:
+            group-by: single-with-filters
             unique-kinds: false
         worker-type: succeed

taskcluster/gecko_taskgraph/util/dependencies.py

@@ -32,7 +32,7 @@ def skip_only_or_not(config, task):
     return False
 
 
-@group_by("single")
+@group_by("single-with-filters")
 def single_grouping(config, tasks):
     for task in tasks:
         if skip_only_or_not(config.config, task):