Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-01-16 23:25:03 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1690495: Make bookmarks toolbar to batch update when addition/removal. r=Standard8

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D104140
This commit is contained in:
Daisuke Akatsuka 2021-02-08 23:34:04 +00:00
parent d04982edda
commit 4e53274e59
1 changed files with 18 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
browser/base/content/browser-places.js
View File

@ -2311,6 +2311,9 @@ var BookmarkingUI = {
},
handlePlacesEvents(aEvents) {
let isStarUpdateNeeded = false;
let affectsOtherBookmarksFolder = false;
for (let ev of aEvents) {
switch (ev.type) {
case "bookmark-added":
@ -2320,7 +2323,7 @@ var BookmarkingUI = {
// If a new bookmark has been added to the tracked uri, register it.
if (!this._itemGuids.has(ev.guid)) {
this._itemGuids.add(ev.guid);
this._updateStar();
isStarUpdateNeeded = true;
}
}
}
@ -2331,17 +2334,26 @@ var BookmarkingUI = {
this._itemGuids.delete(ev.guid);
// Only need to update the UI if the page is no longer starred
if (this._itemGuids.size == 0) {
this._updateStar();
isStarUpdateNeeded = true;
}
}
break;
}
if (ev.parentGuid === PlacesUtils.bookmarks.unfiledGuid) {
this.maybeShowOtherBookmarksFolder();
affectsOtherBookmarksFolder = true;
}
this.updateEmptyToolbarMessage();
}
if (isStarUpdateNeeded) {
this._updateStar();
}
if (affectsOtherBookmarksFolder) {
this.maybeShowOtherBookmarksFolder();
}
this.updateEmptyToolbarMessage();
},
onItemChanged(
@ -2434,11 +2446,10 @@ var BookmarkingUI = {
SHOW_OTHER_BOOKMARKS &&
placement?.area == CustomizableUI.AREA_BOOKMARKS
) {
let result = PlacesUtils.getFolderContents(unfiledGuid);
let node = result.root;
// Build the "Other Bookmarks" button if it doesn't exist.
if (!otherBookmarks) {
const result = PlacesUtils.getFolderContents(unfiledGuid);
const node = result.root;
this.buildOtherBookmarksFolder(node);
}