Bug 1122999 - Mark the fOuter member defined by NS_DECL_AGGREGATED as unsafe; r=froydnj

2024-10-09 03:15:11 +00:00 · 2015-01-17 20:15:26 -05:00 · 2015-01-17 20:15:26 -05:00 · 4f8f88a90d
commit 4f8f88a90d
parent f555db9bc7
1 changed files with 6 additions and 1 deletions
--- a/xpcom/base/nsAgg.h
+++ b/xpcom/base/nsAgg.h
@ -63,7 +63,12 @@ private:                                                                    \
                                                                            \
    friend class Internal;                                                  \
                                                                            \
-    nsISupports*        fOuter;                                             \
+    nsISupports* MOZ_UNSAFE_REF("fOuter can either point to fAggregated "   \
+                                "or to an outer object, and the safety "    \
+                                "of this reference depends on the exact "   \
+                                "lifetime semantics of the AddRef/Release " \
+                                "functions created by these macros.")       \
+                        fOuter;                                             \
    Internal            fAggregated;                                        \
                                                                            \
 public:                                                                     \