Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-08 02:14:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1601235 - Remove the second arg of nsIXULBrowserWindow::SetOverLink. r=bzbarsky

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D55946

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Masatoshi Kimura 2019-12-05 14:23:01 +00:00
parent 6ec41d71d2
commit 502bc1fe35
9 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
browser/base/content/browser.js
View File

@ -5136,7 +5136,7 @@ var XULBrowserWindow = {
StatusPanel.update();
},
setOverLink(url, anchorElt) {
setOverLink(url) {
if (url) {
url = Services.textToSubURI.unEscapeURIForUI("UTF-8", url);
@ -5370,7 +5370,7 @@ var XULBrowserWindow = {
var location = aLocationURI ? aLocationURI.spec : "";
this.hideOverLinkImmediately = true;
this.setOverLink("", null);
this.setOverLink("");
this.hideOverLinkImmediately = false;
// We should probably not do this if the value has changed since the user

2
browser/components/places/PlacesUIUtils.jsm
View File

@ -1129,7 +1129,7 @@ var PlacesUIUtils = {
// unload event happens after the browser's one. In this case
// top.XULBrowserWindow has been nullified already.
if (win.top.XULBrowserWindow) {
win.top.XULBrowserWindow.setOverLink(url, null);
win.top.XULBrowserWindow.setOverLink(url);
}
},
};

4
browser/components/places/content/browserPlacesViews.js
View File

@ -1659,12 +1659,12 @@ PlacesToolbar.prototype = {
button._placesNode &&
PlacesUtils.nodeIsURI(button._placesNode)
) {
window.XULBrowserWindow.setOverLink(aEvent.target._placesNode.uri, null);
window.XULBrowserWindow.setOverLink(aEvent.target._placesNode.uri);
}
},
_onMouseOut: function PT__onMouseOut(aEvent) {
window.XULBrowserWindow.setOverLink("", null);
window.XULBrowserWindow.setOverLink("");
},
_onMouseDown: function PT__onMouseDown(aEvent) {

4
browser/components/places/content/places-menupopup.js
View File

@ -389,7 +389,7 @@
}
if (linkURI) {
window.XULBrowserWindow.setOverLink(linkURI, null);
window.XULBrowserWindow.setOverLink(linkURI);
}
}
}
@ -401,7 +401,7 @@
}
if (window.XULBrowserWindow) {
window.XULBrowserWindow.setOverLink("", null);
window.XULBrowserWindow.setOverLink("");
}
}

2
dom/ipc/BrowserParent.cpp
View File

@ -2027,7 +2027,7 @@ mozilla::ipc::IPCResult BrowserParent::RecvSetLinkStatus(
return IPC_OK();
}
xulBrowserWindow->SetOverLink(aStatus, nullptr);
xulBrowserWindow->SetOverLink(aStatus);
return IPC_OK();
}

2
toolkit/content/tests/chrome/findbar_window.xhtml
View File

@ -48,7 +48,7 @@
throw Cr.NS_NOINTERFACE;
},
setOverLink: function(aStatusText, aLink) {
setOverLink: function(aStatusText) {
gStatusText = aStatusText;
},

2
toolkit/content/widgets/findbar.js
View File

@ -755,7 +755,7 @@
// Call this has the same effect like hovering over link,
// the browser shows the URL as a tooltip.
this._xulBrowserWindow.setOverLink(foundURL || "", null);
this._xulBrowserWindow.setOverLink(foundURL || "");
return true;
}

2
xpfe/appshell/nsContentTreeOwner.cpp
View File

@ -404,7 +404,7 @@ NS_IMETHODIMP nsContentTreeOwner::SetLinkStatus(const nsAString& aStatusText) {
mAppWindow->GetXULBrowserWindow(getter_AddRefs(xulBrowserWindow));
if (xulBrowserWindow) {
xulBrowserWindow->SetOverLink(aStatusText, nullptr);
xulBrowserWindow->SetOverLink(aStatusText);
}
return NS_OK;

2
xpfe/appshell/nsIXULBrowserWindow.idl
View File

@ -32,7 +32,7 @@ interface nsIXULBrowserWindow : nsISupports
* Tells the object implementing this function what link we are currently
* over.
*/
void setOverLink(in AString link, in Element element);
void setOverLink(in AString link);
/**
* Determines the appropriate target for a link.