mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-12-13 10:25:01 +00:00
Changed a comment in UserField.pm to be more accurate: it is actually safe to change the userID on the fly from an undefined value to a defined value because the code only uses it at two points: creation, if it was defined (used by the caller) and destruction (at which point it is passed to the data source to save any changes).
This commit is contained in:
parent
ceb11d6d7f
commit
503d696c7e
@ -58,7 +58,7 @@ sub init {
|
||||
my($app, $user, $fieldID, $fieldCategory, $fieldName, $fieldTypeData, $fieldMode, $fieldData) = @_;
|
||||
# do not hold on to $user!
|
||||
$self->app($app);
|
||||
$self->userID($user->userID); # change this at your peril
|
||||
$self->userID($user->userID); # only change this if it started as undef
|
||||
$self->fieldID($fieldID); # change this at your peril
|
||||
$self->category($fieldCategory); # change this at your peril
|
||||
$self->name($fieldName); # change this at your peril
|
||||
|
Loading…
Reference in New Issue
Block a user