From 515c09fa736fc8c771e54e3a883376f3a263f412 Mon Sep 17 00:00:00 2001 From: James Teh Date: Wed, 26 Feb 2020 00:36:02 +0000 Subject: [PATCH] Bug 1602692: Enable a11y tests for Fission which depend on TakeFocus. r=yzen nsFocusManager::SetFocus (and thus Accessible::TakeFocus) was fixed for Fission in bug 1556627. Most of these tests now pass without modification. browser_caching_value.js needed to be tweaked slightly to synthesize a key in the OOP iframe instead of the top level document. Differential Revision: https://phabricator.services.mozilla.com/D64254 --HG-- extra : moz-landing-system : lando --- accessible/tests/browser/e10s/browser.ini | 4 ---- accessible/tests/browser/e10s/browser_caching_value.js | 8 +++++++- accessible/tests/browser/fission/browser.ini | 1 - 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/accessible/tests/browser/e10s/browser.ini b/accessible/tests/browser/e10s/browser.ini index 64ebc5cd4bfe..494797d0223c 100644 --- a/accessible/tests/browser/e10s/browser.ini +++ b/accessible/tests/browser/e10s/browser.ini @@ -15,20 +15,17 @@ support-files = # Caching tests [browser_caching_attributes.js] -skip-if = fission # Bug 1556627 [browser_caching_description.js] [browser_caching_name.js] skip-if = (os == "linux" && bits == 64) || (debug && os == "mac") || (debug && os == "win") #Bug 1388256 [browser_caching_relations.js] [browser_caching_states.js] [browser_caching_value.js] -skip-if = fission # Bug 1556627 # Events tests [browser_events_announcement.js] skip-if = e10s && os == 'win' # Bug 1288839 [browser_events_caretmove.js] -skip-if = fission # Bug 1556627 [browser_events_hide.js] [browser_events_show.js] [browser_events_statechange.js] @@ -52,7 +49,6 @@ skip-if = e10s && os == 'win' # Bug 1288839 [browser_treeupdate_optgroup.js] [browser_treeupdate_removal.js] [browser_treeupdate_select_dropdown.js] -skip-if = fission # Bug 1556627 [browser_treeupdate_table.js] [browser_treeupdate_textleaf.js] [browser_treeupdate_visibility.js] diff --git a/accessible/tests/browser/e10s/browser_caching_value.js b/accessible/tests/browser/e10s/browser_caching_value.js index 60c201ddbc31..c727fc5252d0 100644 --- a/accessible/tests/browser/e10s/browser_caching_value.js +++ b/accessible/tests/browser/e10s/browser_caching_value.js @@ -136,7 +136,13 @@ const valueTests = [ id: "range", async action(browser) { await invokeFocus(browser, "range"); - await BrowserTestUtils.synthesizeKey("VK_LEFT", {}, browser); + await invokeContentTask(browser, [], () => { + const { ContentTaskUtils } = ChromeUtils.import( + "resource://testing-common/ContentTaskUtils.jsm" + ); + const EventUtils = ContentTaskUtils.getEventUtils(content); + EventUtils.synthesizeKey("VK_LEFT", {}, content); + }); }, waitFor: EVENT_VALUE_CHANGE, expected: "5", diff --git a/accessible/tests/browser/fission/browser.ini b/accessible/tests/browser/fission/browser.ini index 8d53548d1ee5..a3fc7aa8390b 100644 --- a/accessible/tests/browser/fission/browser.ini +++ b/accessible/tests/browser/fission/browser.ini @@ -12,4 +12,3 @@ support-files = [browser_reframe_visibility.js] [browser_src_change.js] [browser_take_focus.js] -skip-if = fission # Bug 1556627