Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-08 10:44:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1341137 part 1 - Make Selection::addRange silently reject ranges that have a different root. r=smaug

Browse Source
This commit is contained in:
Mats Palmgren 2017-02-25 00:26:18 +01:00
parent 73c8a5366c
commit 51817b4c94
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
layout/generic/nsSelection.cpp
View File

@ -4964,6 +4964,16 @@ Selection::AddRange(nsIDOMRange* aDOMRange)
void
Selection::AddRange(nsRange& aRange, ErrorResult& aRv)
{
nsINode* rangeRoot = aRange.GetRoot();
nsIDocument* doc = GetParentObject();
if (doc != rangeRoot && (!rangeRoot ||
doc != rangeRoot->GetComposedDoc())) {
// http://w3c.github.io/selection-api/#dom-selection-addrange
// "... if the root of the range's boundary points are the document
// associated with context object. Otherwise, this method must do nothing."
return;
}
// This inserts a table cell range in proper document order
// and returns NS_OK if range doesn't contain just one table cell
bool didAddRange;