diff --git a/js/src/asmjs/WasmIonCompile.cpp b/js/src/asmjs/WasmIonCompile.cpp index 3cd4b264e275..57ec1dcea5ad 100644 --- a/js/src/asmjs/WasmIonCompile.cpp +++ b/js/src/asmjs/WasmIonCompile.cpp @@ -665,7 +665,7 @@ class FunctionCompiler { if (inDeadCode()) return nullptr; - auto* ins = MAsmSelect::New(alloc(), trueExpr, falseExpr, condExpr); + auto* ins = MWasmSelect::New(alloc(), trueExpr, falseExpr, condExpr); curBlock_->add(ins); return ins; } diff --git a/js/src/jit/MIR.h b/js/src/jit/MIR.h index 0452f3d6ae24..4e40733c68ce 100644 --- a/js/src/jit/MIR.h +++ b/js/src/jit/MIR.h @@ -14050,11 +14050,11 @@ class MWasmCall final } }; -class MAsmSelect +class MWasmSelect : public MTernaryInstruction, public NoTypePolicy::Data { - MAsmSelect(MDefinition* trueExpr, MDefinition* falseExpr, MDefinition *condExpr) + MWasmSelect(MDefinition* trueExpr, MDefinition* falseExpr, MDefinition *condExpr) : MTernaryInstruction(trueExpr, falseExpr, condExpr) { MOZ_ASSERT(condExpr->type() == MIRType::Int32); @@ -14064,7 +14064,7 @@ class MAsmSelect } public: - INSTRUCTION_HEADER(AsmSelect) + INSTRUCTION_HEADER(WasmSelect) TRIVIAL_NEW_WRAPPERS NAMED_OPERANDS((0, trueExpr), (1, falseExpr), (2, condExpr)) @@ -14076,7 +14076,7 @@ class MAsmSelect return congruentIfOperandsEqual(ins); } - ALLOW_CLONE(MAsmSelect) + ALLOW_CLONE(MWasmSelect) }; class MWasmReinterpret diff --git a/js/src/jit/MOpcodes.h b/js/src/jit/MOpcodes.h index e43a62909ae5..b9b2a1d361a3 100644 --- a/js/src/jit/MOpcodes.h +++ b/js/src/jit/MOpcodes.h @@ -290,7 +290,7 @@ namespace jit { _(AsmJSVoidReturn) \ _(AsmJSPassStackArg) \ _(WasmCall) \ - _(AsmSelect) \ + _(WasmSelect) \ _(WasmReinterpret) \ _(Rotate) \ _(NewDerivedTypedObject) \ diff --git a/js/src/jit/arm/CodeGenerator-arm.cpp b/js/src/jit/arm/CodeGenerator-arm.cpp index a48a3659a536..6b4340633546 100644 --- a/js/src/jit/arm/CodeGenerator-arm.cpp +++ b/js/src/jit/arm/CodeGenerator-arm.cpp @@ -2171,7 +2171,7 @@ CodeGeneratorARM::visitAtomicTypedArrayElementBinopForEffect(LAtomicTypedArrayEl } void -CodeGeneratorARM::visitAsmSelect(LAsmSelect* ins) +CodeGeneratorARM::visitWasmSelect(LWasmSelect* ins) { MIRType mirType = ins->mir()->type(); @@ -2196,7 +2196,7 @@ CodeGeneratorARM::visitAsmSelect(LAsmSelect* ins) else if (mirType == MIRType::Float32) masm.moveFloat32(falseExpr, out, Assembler::Zero); else - MOZ_CRASH("unhandled type in visitAsmSelect!"); + MOZ_CRASH("unhandled type in visitWasmSelect!"); } void @@ -3633,7 +3633,7 @@ CodeGeneratorARM::visitAsmJSPassStackArgI64(LAsmJSPassStackArgI64* ins) } void -CodeGeneratorARM::visitAsmSelectI64(LAsmSelectI64* lir) +CodeGeneratorARM::visitWasmSelectI64(LWasmSelectI64* lir) { Register cond = ToRegister(lir->condExpr()); const LInt64Allocation falseExpr = lir->falseExpr(); diff --git a/js/src/jit/arm/CodeGenerator-arm.h b/js/src/jit/arm/CodeGenerator-arm.h index 688042b1abbf..ec89486f9c72 100644 --- a/js/src/jit/arm/CodeGenerator-arm.h +++ b/js/src/jit/arm/CodeGenerator-arm.h @@ -179,7 +179,7 @@ class CodeGeneratorARM : public CodeGeneratorShared virtual void visitBitOpI64(LBitOpI64* lir); virtual void visitRotateI64(LRotateI64* lir); virtual void visitAsmJSPassStackArgI64(LAsmJSPassStackArgI64* lir); - virtual void visitAsmSelectI64(LAsmSelectI64* lir); + virtual void visitWasmSelectI64(LWasmSelectI64* lir); virtual void visitWasmReinterpretFromI64(LWasmReinterpretFromI64* lir); virtual void visitWasmReinterpretToI64(LWasmReinterpretToI64* lir); virtual void visitPopcntI64(LPopcntI64* ins); @@ -233,7 +233,7 @@ class CodeGeneratorARM : public CodeGeneratorShared void visitAtomicTypedArrayElementBinopForEffect(LAtomicTypedArrayElementBinopForEffect* lir); void visitCompareExchangeTypedArrayElement(LCompareExchangeTypedArrayElement* lir); void visitAtomicExchangeTypedArrayElement(LAtomicExchangeTypedArrayElement* lir); - void visitAsmSelect(LAsmSelect* ins); + void visitWasmSelect(LWasmSelect* ins); void visitWasmReinterpret(LWasmReinterpret* ins); void emitWasmCall(LWasmCallBase* ins); void visitWasmCall(LWasmCall* ins); diff --git a/js/src/jit/arm/Lowering-arm.cpp b/js/src/jit/arm/Lowering-arm.cpp index 57a41eb922dd..175dcc7aef68 100644 --- a/js/src/jit/arm/Lowering-arm.cpp +++ b/js/src/jit/arm/Lowering-arm.cpp @@ -514,24 +514,22 @@ LIRGeneratorARM::lowerUrshD(MUrsh* mir) } void -LIRGeneratorARM::visitAsmSelect(MAsmSelect* ins) +LIRGeneratorARM::visitWasmSelect(MWasmSelect* ins) { if (ins->type() == MIRType::Int64) { - auto* lir = new(alloc()) LAsmSelectI64(useInt64RegisterAtStart(ins->trueExpr()), - useInt64(ins->falseExpr()), - useRegister(ins->condExpr()) - ); + auto* lir = new(alloc()) LWasmSelectI64(useInt64RegisterAtStart(ins->trueExpr()), + useInt64(ins->falseExpr()), + useRegister(ins->condExpr())); - defineInt64ReuseInput(lir, ins, LAsmSelectI64::TrueExprIndex); + defineInt64ReuseInput(lir, ins, LWasmSelectI64::TrueExprIndex); return; } - auto* lir = new(alloc()) LAsmSelect(useRegisterAtStart(ins->trueExpr()), - useRegister(ins->falseExpr()), - useRegister(ins->condExpr()) - ); + auto* lir = new(alloc()) LWasmSelect(useRegisterAtStart(ins->trueExpr()), + useRegister(ins->falseExpr()), + useRegister(ins->condExpr())); - defineReuseInput(lir, ins, LAsmSelect::TrueExprIndex); + defineReuseInput(lir, ins, LWasmSelect::TrueExprIndex); } void diff --git a/js/src/jit/arm/Lowering-arm.h b/js/src/jit/arm/Lowering-arm.h index db3c87f5b9df..617517e1bf63 100644 --- a/js/src/jit/arm/Lowering-arm.h +++ b/js/src/jit/arm/Lowering-arm.h @@ -102,7 +102,7 @@ class LIRGeneratorARM : public LIRGeneratorShared void lowerPhi(MPhi* phi); void visitGuardShape(MGuardShape* ins); void visitGuardObjectGroup(MGuardObjectGroup* ins); - void visitAsmSelect(MAsmSelect* ins); + void visitWasmSelect(MWasmSelect* ins); void visitAsmJSUnsignedToDouble(MAsmJSUnsignedToDouble* ins); void visitAsmJSUnsignedToFloat32(MAsmJSUnsignedToFloat32* ins); void visitWasmLoad(MWasmLoad* ins); diff --git a/js/src/jit/arm64/Lowering-arm64.cpp b/js/src/jit/arm64/Lowering-arm64.cpp index d5e6364f513c..44933a1e5ebc 100644 --- a/js/src/jit/arm64/Lowering-arm64.cpp +++ b/js/src/jit/arm64/Lowering-arm64.cpp @@ -222,9 +222,9 @@ LIRGeneratorARM64::visitAsmJSNeg(MAsmJSNeg* ins) } void -LIRGeneratorARM64::visitAsmSelect(MAsmSelect* ins) +LIRGeneratorARM64::visitWasmSelect(MWasmSelect* ins) { - MOZ_CRASH("visitAsmSelect"); + MOZ_CRASH("visitWasmSelect"); } void diff --git a/js/src/jit/arm64/Lowering-arm64.h b/js/src/jit/arm64/Lowering-arm64.h index 102670a9fd84..0a2b82983817 100644 --- a/js/src/jit/arm64/Lowering-arm64.h +++ b/js/src/jit/arm64/Lowering-arm64.h @@ -89,7 +89,7 @@ class LIRGeneratorARM64 : public LIRGeneratorShared void lowerUMod(MMod* mod); void visitPowHalf(MPowHalf* ins); void visitAsmJSNeg(MAsmJSNeg* ins); - void visitAsmSelect(MAsmSelect* ins); + void visitWasmSelect(MWasmSelect* ins); LTableSwitchV* newLTableSwitchV(MTableSwitch* ins); LTableSwitch* newLTableSwitch(const LAllocation& in, diff --git a/js/src/jit/mips-shared/CodeGenerator-mips-shared.cpp b/js/src/jit/mips-shared/CodeGenerator-mips-shared.cpp index 9f4d1b1aab94..3074c3b45bc2 100644 --- a/js/src/jit/mips-shared/CodeGenerator-mips-shared.cpp +++ b/js/src/jit/mips-shared/CodeGenerator-mips-shared.cpp @@ -2335,7 +2335,7 @@ CodeGeneratorMIPSShared::visitAsmJSPassStackArgI64(LAsmJSPassStackArgI64* ins) } void -CodeGeneratorMIPSShared::visitAsmSelect(LAsmSelect* ins) +CodeGeneratorMIPSShared::visitWasmSelect(LWasmSelect* ins) { MIRType mirType = ins->mir()->type(); @@ -2358,7 +2358,7 @@ CodeGeneratorMIPSShared::visitAsmSelect(LAsmSelect* ins) else if (mirType == MIRType::Double) masm.as_movz(Assembler::DoubleFloat, out, ToFloatRegister(falseExpr), cond); else - MOZ_CRASH("unhandled type in visitAsmSelect!"); + MOZ_CRASH("unhandled type in visitWasmSelect!"); } else { Label done; masm.ma_b(cond, cond, &done, Assembler::NonZero, ShortJump); @@ -2368,7 +2368,7 @@ CodeGeneratorMIPSShared::visitAsmSelect(LAsmSelect* ins) else if (mirType == MIRType::Double) masm.loadDouble(ToAddress(falseExpr), out); else - MOZ_CRASH("unhandled type in visitAsmSelect!"); + MOZ_CRASH("unhandled type in visitWasmSelect!"); masm.bind(&done); } diff --git a/js/src/jit/mips-shared/CodeGenerator-mips-shared.h b/js/src/jit/mips-shared/CodeGenerator-mips-shared.h index 078bbcf0d4ea..6530e1497e91 100644 --- a/js/src/jit/mips-shared/CodeGenerator-mips-shared.h +++ b/js/src/jit/mips-shared/CodeGenerator-mips-shared.h @@ -231,7 +231,7 @@ class CodeGeneratorMIPSShared : public CodeGeneratorShared void visitAsmJSPassStackArg(LAsmJSPassStackArg* ins); void visitAsmJSPassStackArgI64(LAsmJSPassStackArgI64* ins); - void visitAsmSelect(LAsmSelect* ins); + void visitWasmSelect(LWasmSelect* ins); void visitWasmReinterpret(LWasmReinterpret* ins); void visitMemoryBarrier(LMemoryBarrier* ins); diff --git a/js/src/jit/mips-shared/Lowering-mips-shared.cpp b/js/src/jit/mips-shared/Lowering-mips-shared.cpp index 4aac70d4b338..55db25e3a416 100644 --- a/js/src/jit/mips-shared/Lowering-mips-shared.cpp +++ b/js/src/jit/mips-shared/Lowering-mips-shared.cpp @@ -406,24 +406,22 @@ LIRGeneratorMIPSShared::visitWasmStore(MWasmStore* ins) } void -LIRGeneratorMIPSShared::visitAsmSelect(MAsmSelect* ins) +LIRGeneratorMIPSShared::visitWasmSelect(MWasmSelect* ins) { if (ins->type() == MIRType::Int64) { - auto* lir = new(alloc()) LAsmSelectI64(useInt64RegisterAtStart(ins->trueExpr()), - useInt64(ins->falseExpr()), - useRegister(ins->condExpr()) - ); + auto* lir = new(alloc()) LWasmSelectI64(useInt64RegisterAtStart(ins->trueExpr()), + useInt64(ins->falseExpr()), + useRegister(ins->condExpr())); - defineInt64ReuseInput(lir, ins, LAsmSelectI64::TrueExprIndex); + defineInt64ReuseInput(lir, ins, LWasmSelectI64::TrueExprIndex); return; } - auto* lir = new(alloc()) LAsmSelect(useRegisterAtStart(ins->trueExpr()), - use(ins->falseExpr()), - useRegister(ins->condExpr()) - ); + auto* lir = new(alloc()) LWasmSelect(useRegisterAtStart(ins->trueExpr()), + use(ins->falseExpr()), + useRegister(ins->condExpr())); - defineReuseInput(lir, ins, LAsmSelect::TrueExprIndex); + defineReuseInput(lir, ins, LWasmSelect::TrueExprIndex); } void diff --git a/js/src/jit/mips-shared/Lowering-mips-shared.h b/js/src/jit/mips-shared/Lowering-mips-shared.h index 0acfc569ac9d..0652727c48de 100644 --- a/js/src/jit/mips-shared/Lowering-mips-shared.h +++ b/js/src/jit/mips-shared/Lowering-mips-shared.h @@ -73,7 +73,7 @@ class LIRGeneratorMIPSShared : public LIRGeneratorShared void visitAsmJSNeg(MAsmJSNeg* ins); void visitWasmLoad(MWasmLoad* ins); void visitWasmStore(MWasmStore* ins); - void visitAsmSelect(MAsmSelect* ins); + void visitWasmSelect(MWasmSelect* ins); LTableSwitch* newLTableSwitch(const LAllocation& in, const LDefinition& inputCopy, MTableSwitch* ins); diff --git a/js/src/jit/mips32/CodeGenerator-mips32.cpp b/js/src/jit/mips32/CodeGenerator-mips32.cpp index 1ae27847f7eb..1f58a8f0f994 100644 --- a/js/src/jit/mips32/CodeGenerator-mips32.cpp +++ b/js/src/jit/mips32/CodeGenerator-mips32.cpp @@ -645,7 +645,7 @@ CodeGeneratorMIPS::visitWasmStoreGlobalVarI64(LWasmStoreGlobalVarI64* ins) } void -CodeGeneratorMIPS::visitAsmSelectI64(LAsmSelectI64* lir) +CodeGeneratorMIPS::visitWasmSelectI64(LWasmSelectI64* lir) { MOZ_ASSERT(lir->mir()->type() == MIRType::Int64); Register cond = ToRegister(lir->condExpr()); diff --git a/js/src/jit/mips32/CodeGenerator-mips32.h b/js/src/jit/mips32/CodeGenerator-mips32.h index c788e34c636c..fc4394b65397 100644 --- a/js/src/jit/mips32/CodeGenerator-mips32.h +++ b/js/src/jit/mips32/CodeGenerator-mips32.h @@ -53,7 +53,7 @@ class CodeGeneratorMIPS : public CodeGeneratorMIPSShared void visitWasmUnalignedStoreI64(LWasmUnalignedStoreI64* ins); void visitWasmLoadGlobalVarI64(LWasmLoadGlobalVarI64* ins); void visitWasmStoreGlobalVarI64(LWasmStoreGlobalVarI64* ins); - void visitAsmSelectI64(LAsmSelectI64* lir); + void visitWasmSelectI64(LWasmSelectI64* lir); void visitWasmReinterpretFromI64(LWasmReinterpretFromI64* lir); void visitWasmReinterpretToI64(LWasmReinterpretToI64* lir); void visitExtendInt32ToInt64(LExtendInt32ToInt64* lir); diff --git a/js/src/jit/mips64/CodeGenerator-mips64.cpp b/js/src/jit/mips64/CodeGenerator-mips64.cpp index a56a8c313232..5056f79ab3ed 100644 --- a/js/src/jit/mips64/CodeGenerator-mips64.cpp +++ b/js/src/jit/mips64/CodeGenerator-mips64.cpp @@ -559,7 +559,7 @@ CodeGeneratorMIPS64::visitWasmStoreGlobalVarI64(LWasmStoreGlobalVarI64* ins) } void -CodeGeneratorMIPS64::visitAsmSelectI64(LAsmSelectI64* lir) +CodeGeneratorMIPS64::visitWasmSelectI64(LWasmSelectI64* lir) { MOZ_ASSERT(lir->mir()->type() == MIRType::Int64); diff --git a/js/src/jit/mips64/CodeGenerator-mips64.h b/js/src/jit/mips64/CodeGenerator-mips64.h index fb0c9f1e5f25..3c859ef4c778 100644 --- a/js/src/jit/mips64/CodeGenerator-mips64.h +++ b/js/src/jit/mips64/CodeGenerator-mips64.h @@ -59,7 +59,7 @@ class CodeGeneratorMIPS64 : public CodeGeneratorMIPSShared void visitWasmUnalignedStoreI64(LWasmUnalignedStoreI64* ins); void visitWasmLoadGlobalVarI64(LWasmLoadGlobalVarI64* ins); void visitWasmStoreGlobalVarI64(LWasmStoreGlobalVarI64* ins); - void visitAsmSelectI64(LAsmSelectI64* ins); + void visitWasmSelectI64(LWasmSelectI64* ins); void visitWasmReinterpretFromI64(LWasmReinterpretFromI64* lir); void visitWasmReinterpretToI64(LWasmReinterpretToI64* lir); void visitExtendInt32ToInt64(LExtendInt32ToInt64* lir); diff --git a/js/src/jit/none/Lowering-none.h b/js/src/jit/none/Lowering-none.h index b5daff55aa73..83da5b090636 100644 --- a/js/src/jit/none/Lowering-none.h +++ b/js/src/jit/none/Lowering-none.h @@ -88,7 +88,7 @@ class LIRGeneratorNone : public LIRGeneratorShared void visitAsmJSCompareExchangeHeap(MAsmJSCompareExchangeHeap* ins) { MOZ_CRASH(); } void visitAsmJSAtomicExchangeHeap(MAsmJSAtomicExchangeHeap* ins) { MOZ_CRASH(); } void visitAsmJSAtomicBinopHeap(MAsmJSAtomicBinopHeap* ins) { MOZ_CRASH(); } - void visitAsmSelect(MAsmSelect*) { MOZ_CRASH(); } + void visitWasmSelect(MWasmSelect*) { MOZ_CRASH(); } void visitWasmBoundsCheck(MWasmBoundsCheck* ins) { MOZ_CRASH(); } void visitWasmLoad(MWasmLoad* ins) { MOZ_CRASH(); } void visitWasmStore(MWasmStore* ins) { MOZ_CRASH(); } diff --git a/js/src/jit/shared/LIR-shared.h b/js/src/jit/shared/LIR-shared.h index a6aa5f520960..11b4f052b5e5 100644 --- a/js/src/jit/shared/LIR-shared.h +++ b/js/src/jit/shared/LIR-shared.h @@ -7836,26 +7836,28 @@ class LHasClass : public LInstructionHelper<1, 1, 0> }; template -class LAsmSelectBase : public LInstructionHelper +class LWasmSelectBase : public LInstructionHelper { typedef LInstructionHelper Base; public: - MAsmSelect* mir() const { - return Base::mir_->toAsmSelect(); + MWasmSelect* mir() const { + return Base::mir_->toWasmSelect(); } }; -class LAsmSelect : public LAsmSelectBase<1, 3> +class LWasmSelect : public LWasmSelectBase<1, 3> { public: - LIR_HEADER(AsmSelect); + LIR_HEADER(WasmSelect); static const size_t TrueExprIndex = 0; static const size_t FalseExprIndex = 1; static const size_t CondIndex = 2; - LAsmSelect(const LAllocation& trueExpr, const LAllocation& falseExpr, const LAllocation& cond) { + LWasmSelect(const LAllocation& trueExpr, const LAllocation& falseExpr, + const LAllocation& cond) + { setOperand(TrueExprIndex, trueExpr); setOperand(FalseExprIndex, falseExpr); setOperand(CondIndex, cond); @@ -7872,17 +7874,17 @@ class LAsmSelect : public LAsmSelectBase<1, 3> } }; -class LAsmSelectI64 : public LAsmSelectBase +class LWasmSelectI64 : public LWasmSelectBase { public: - LIR_HEADER(AsmSelectI64); + LIR_HEADER(WasmSelectI64); static const size_t TrueExprIndex = 0; static const size_t FalseExprIndex = INT64_PIECES; static const size_t CondIndex = INT64_PIECES * 2; - LAsmSelectI64(const LInt64Allocation& trueExpr, const LInt64Allocation& falseExpr, - const LAllocation& cond) + LWasmSelectI64(const LInt64Allocation& trueExpr, const LInt64Allocation& falseExpr, + const LAllocation& cond) { setInt64Operand(TrueExprIndex, trueExpr); setInt64Operand(FalseExprIndex, falseExpr); diff --git a/js/src/jit/shared/LOpcodes-shared.h b/js/src/jit/shared/LOpcodes-shared.h index d2cbbc1d9e8b..704e172f3aac 100644 --- a/js/src/jit/shared/LOpcodes-shared.h +++ b/js/src/jit/shared/LOpcodes-shared.h @@ -389,8 +389,8 @@ _(IsObject) \ _(IsObjectAndBranch) \ _(HasClass) \ - _(AsmSelect) \ - _(AsmSelectI64) \ + _(WasmSelect) \ + _(WasmSelectI64) \ _(WasmBoundsCheck) \ _(WasmAddOffset) \ _(WasmLoad) \ diff --git a/js/src/jit/x64/CodeGenerator-x64.cpp b/js/src/jit/x64/CodeGenerator-x64.cpp index 5a5badc26b1f..75a72c328c7e 100644 --- a/js/src/jit/x64/CodeGenerator-x64.cpp +++ b/js/src/jit/x64/CodeGenerator-x64.cpp @@ -339,7 +339,7 @@ CodeGeneratorX64::visitUDivOrModI64(LUDivOrModI64* lir) } void -CodeGeneratorX64::visitAsmSelectI64(LAsmSelectI64* lir) +CodeGeneratorX64::visitWasmSelectI64(LWasmSelectI64* lir) { MOZ_ASSERT(lir->mir()->type() == MIRType::Int64); diff --git a/js/src/jit/x64/CodeGenerator-x64.h b/js/src/jit/x64/CodeGenerator-x64.h index 3c51989b72eb..87c1d6b0aa15 100644 --- a/js/src/jit/x64/CodeGenerator-x64.h +++ b/js/src/jit/x64/CodeGenerator-x64.h @@ -65,7 +65,7 @@ class CodeGeneratorX64 : public CodeGeneratorX86Shared void visitWasmStoreGlobalVar(LWasmStoreGlobalVar* ins); void visitWasmLoadGlobalVarI64(LWasmLoadGlobalVarI64* ins); void visitWasmStoreGlobalVarI64(LWasmStoreGlobalVarI64* ins); - void visitAsmSelectI64(LAsmSelectI64* ins); + void visitWasmSelectI64(LWasmSelectI64* ins); void visitWasmCall(LWasmCall* ins); void visitWasmCallI64(LWasmCallI64* ins); void visitAsmJSLoadHeap(LAsmJSLoadHeap* ins); diff --git a/js/src/jit/x86-shared/CodeGenerator-x86-shared.cpp b/js/src/jit/x86-shared/CodeGenerator-x86-shared.cpp index db79b5724fbb..1b84baa05ec8 100644 --- a/js/src/jit/x86-shared/CodeGenerator-x86-shared.cpp +++ b/js/src/jit/x86-shared/CodeGenerator-x86-shared.cpp @@ -324,7 +324,7 @@ CodeGeneratorX86Shared::visitAsmJSPassStackArgI64(LAsmJSPassStackArgI64* ins) } void -CodeGeneratorX86Shared::visitAsmSelect(LAsmSelect* ins) +CodeGeneratorX86Shared::visitWasmSelect(LWasmSelect* ins) { MIRType mirType = ins->mir()->type(); @@ -357,7 +357,7 @@ CodeGeneratorX86Shared::visitAsmSelect(LAsmSelect* ins) else masm.loadDouble(falseExpr, out); } else { - MOZ_CRASH("unhandled type in visitAsmSelect!"); + MOZ_CRASH("unhandled type in visitWasmSelect!"); } masm.bind(&done); diff --git a/js/src/jit/x86-shared/CodeGenerator-x86-shared.h b/js/src/jit/x86-shared/CodeGenerator-x86-shared.h index 8fb05a3e1f50..be0d596f67e7 100644 --- a/js/src/jit/x86-shared/CodeGenerator-x86-shared.h +++ b/js/src/jit/x86-shared/CodeGenerator-x86-shared.h @@ -244,7 +244,7 @@ class CodeGeneratorX86Shared : public CodeGeneratorShared virtual void visitUDivOrModConstant(LUDivOrModConstant *ins); virtual void visitAsmJSPassStackArg(LAsmJSPassStackArg* ins); virtual void visitAsmJSPassStackArgI64(LAsmJSPassStackArgI64* ins); - virtual void visitAsmSelect(LAsmSelect* ins); + virtual void visitWasmSelect(LWasmSelect* ins); virtual void visitWasmReinterpret(LWasmReinterpret* lir); virtual void visitMemoryBarrier(LMemoryBarrier* ins); virtual void visitWasmAddOffset(LWasmAddOffset* lir); diff --git a/js/src/jit/x86-shared/Lowering-x86-shared.cpp b/js/src/jit/x86-shared/Lowering-x86-shared.cpp index 9b6590ac8919..8e820070a972 100644 --- a/js/src/jit/x86-shared/Lowering-x86-shared.cpp +++ b/js/src/jit/x86-shared/Lowering-x86-shared.cpp @@ -288,24 +288,22 @@ LIRGeneratorX86Shared::lowerModI(MMod* mod) } void -LIRGeneratorX86Shared::visitAsmSelect(MAsmSelect* ins) +LIRGeneratorX86Shared::visitWasmSelect(MWasmSelect* ins) { if (ins->type() == MIRType::Int64) { - auto* lir = new(alloc()) LAsmSelectI64(useInt64RegisterAtStart(ins->trueExpr()), - useInt64(ins->falseExpr()), - useRegister(ins->condExpr()) - ); + auto* lir = new(alloc()) LWasmSelectI64(useInt64RegisterAtStart(ins->trueExpr()), + useInt64(ins->falseExpr()), + useRegister(ins->condExpr())); - defineInt64ReuseInput(lir, ins, LAsmSelectI64::TrueExprIndex); + defineInt64ReuseInput(lir, ins, LWasmSelectI64::TrueExprIndex); return; } - auto* lir = new(alloc()) LAsmSelect(useRegisterAtStart(ins->trueExpr()), - use(ins->falseExpr()), - useRegister(ins->condExpr()) - ); + auto* lir = new(alloc()) LWasmSelect(useRegisterAtStart(ins->trueExpr()), + use(ins->falseExpr()), + useRegister(ins->condExpr())); - defineReuseInput(lir, ins, LAsmSelect::TrueExprIndex); + defineReuseInput(lir, ins, LWasmSelect::TrueExprIndex); } void diff --git a/js/src/jit/x86-shared/Lowering-x86-shared.h b/js/src/jit/x86-shared/Lowering-x86-shared.h index bf0962b93a49..275cee30195d 100644 --- a/js/src/jit/x86-shared/Lowering-x86-shared.h +++ b/js/src/jit/x86-shared/Lowering-x86-shared.h @@ -47,7 +47,7 @@ class LIRGeneratorX86Shared : public LIRGeneratorShared MDefinition* lhs, MDefinition* rhs); void visitAsmJSNeg(MAsmJSNeg* ins); void lowerWasmLoad(MWasmLoad* ins); - void visitAsmSelect(MAsmSelect* ins); + void visitWasmSelect(MWasmSelect* ins); void lowerMulI(MMul* mul, MDefinition* lhs, MDefinition* rhs); void lowerDivI(MDiv* div); void lowerModI(MMod* mod); diff --git a/js/src/jit/x86/CodeGenerator-x86.cpp b/js/src/jit/x86/CodeGenerator-x86.cpp index d281ee5e3c97..1912681f0718 100644 --- a/js/src/jit/x86/CodeGenerator-x86.cpp +++ b/js/src/jit/x86/CodeGenerator-x86.cpp @@ -1122,7 +1122,7 @@ CodeGeneratorX86::visitUDivOrModI64(LUDivOrModI64* lir) } void -CodeGeneratorX86::visitAsmSelectI64(LAsmSelectI64* lir) +CodeGeneratorX86::visitWasmSelectI64(LWasmSelectI64* lir) { MOZ_ASSERT(lir->mir()->type() == MIRType::Int64); diff --git a/js/src/jit/x86/CodeGenerator-x86.h b/js/src/jit/x86/CodeGenerator-x86.h index 7eef62d4150c..960b8a596746 100644 --- a/js/src/jit/x86/CodeGenerator-x86.h +++ b/js/src/jit/x86/CodeGenerator-x86.h @@ -74,7 +74,7 @@ class CodeGeneratorX86 : public CodeGeneratorX86Shared void visitCompareI64AndBranch(LCompareI64AndBranch* lir); void visitDivOrModI64(LDivOrModI64* lir); void visitUDivOrModI64(LUDivOrModI64* lir); - void visitAsmSelectI64(LAsmSelectI64* lir); + void visitWasmSelectI64(LWasmSelectI64* lir); void visitWasmReinterpretFromI64(LWasmReinterpretFromI64* lir); void visitWasmReinterpretToI64(LWasmReinterpretToI64* lir); void visitExtendInt32ToInt64(LExtendInt32ToInt64* lir);