Bug 1086964 - Remove uses of no_pgo that are no longer needed. r=dmajor

This commit is contained in:
Ryan VanderMeulen 2018-03-14 18:18:32 -04:00
parent 866a8daa39
commit 5383105dd9
6 changed files with 4 additions and 23 deletions

View File

@ -422,11 +422,13 @@ UNIFIED_SOURCES += [
'ipc/UiCompositorControllerParent.cpp', 'ipc/UiCompositorControllerParent.cpp',
'ipc/VideoBridgeChild.cpp', 'ipc/VideoBridgeChild.cpp',
'ipc/VideoBridgeParent.cpp', 'ipc/VideoBridgeParent.cpp',
'Layers.cpp',
'LayerScope.cpp', 'LayerScope.cpp',
'LayersHelpers.cpp', 'LayersHelpers.cpp',
'LayersLogging.cpp', 'LayersLogging.cpp',
'LayerSorter.cpp', 'LayerSorter.cpp',
'LayersTypes.cpp', 'LayersTypes.cpp',
'LayerTreeInvalidation.cpp',
'mlgpu/BufferCache.cpp', 'mlgpu/BufferCache.cpp',
'mlgpu/CanvasLayerMLGPU.cpp', 'mlgpu/CanvasLayerMLGPU.cpp',
'mlgpu/ContainerLayerMLGPU.cpp', 'mlgpu/ContainerLayerMLGPU.cpp',
@ -480,8 +482,6 @@ UNIFIED_SOURCES += [
SOURCES += [ SOURCES += [
'basic/BasicImageLayer.cpp', 'basic/BasicImageLayer.cpp',
'ImageContainer.cpp', 'ImageContainer.cpp',
'Layers.cpp',
'LayerTreeInvalidation.cpp',
'PersistentBufferProvider.cpp', 'PersistentBufferProvider.cpp',
'protobuf/LayerScopePacket.pb.cc', 'protobuf/LayerScopePacket.pb.cc',
'wr/WebRenderTextureHost.cpp', 'wr/WebRenderTextureHost.cpp',
@ -490,14 +490,6 @@ SOURCES += [
DEFINES['GOOGLE_PROTOBUF_NO_RTTI'] = True DEFINES['GOOGLE_PROTOBUF_NO_RTTI'] = True
DEFINES['GOOGLE_PROTOBUF_NO_STATIC_INITIALIZER'] = True DEFINES['GOOGLE_PROTOBUF_NO_STATIC_INITIALIZER'] = True
# Workaround compiler bug (Bug 795594)
if CONFIG['CC_TYPE'] in ('msvc', 'clang-cl') and CONFIG['CPU_ARCH'] == 'x86_64':
for src in [
'Layers.cpp',
'LayerTreeInvalidation.cpp',
]:
SOURCES[src].no_pgo = True
if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'cocoa': if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'cocoa':
SOURCES += [ SOURCES += [
'basic/MacIOSurfaceTextureHostBasic.cpp', 'basic/MacIOSurfaceTextureHostBasic.cpp',

View File

@ -414,8 +414,8 @@ UNIFIED_SOURCES += [
# builtin/Array.cpp and vm/JSAtom.cpp cannot be built in unified mode because # builtin/Array.cpp and vm/JSAtom.cpp cannot be built in unified mode because
# xpcshell is broken during packaging when compiled with gcc-4.8.2 # xpcshell is broken during packaging when compiled with gcc-4.8.2
# builtin/RegExp.cpp cannot be built in unified mode because it is built # builtin/RegExp.cpp cannot be built in unified mode because it causes huge
# without PGO # win32 test slowdowns
# frontend/Parser.cpp cannot be built in unified mode because of explicit # frontend/Parser.cpp cannot be built in unified mode because of explicit
# template instantiations. # template instantiations.
# jsmath.cpp cannot be built in unified mode because it needs to re-#define the # jsmath.cpp cannot be built in unified mode because it needs to re-#define the
@ -724,10 +724,6 @@ if CONFIG['MOZ_LINKER']:
DEFINES['MOZ_LINKER'] = True DEFINES['MOZ_LINKER'] = True
if CONFIG['CC_TYPE'] in ('msvc', 'clang-cl'): if CONFIG['CC_TYPE'] in ('msvc', 'clang-cl'):
if CONFIG['CPU_ARCH'] == 'x86':
SOURCES['builtin/RegExp.cpp'].no_pgo = True # Bug 772303
elif CONFIG['CPU_ARCH'] == 'x86_64' and CONFIG['JS_HAS_CTYPES']:
SOURCES['ctypes/CTypes.cpp'].no_pgo = True # Bug 810661
# Prevent floating point errors caused by VC++ optimizations # Prevent floating point errors caused by VC++ optimizations
# XXX We should add this to CXXFLAGS, too? # XXX We should add this to CXXFLAGS, too?
CFLAGS += ['-fp:precise'] CFLAGS += ['-fp:precise']

View File

@ -30,7 +30,5 @@ if CONFIG['OS_TARGET'] == 'WINNT':
else: else:
DEFINES['__Userspace_os_%s' % CONFIG['OS_TARGET']] = 1 DEFINES['__Userspace_os_%s' % CONFIG['OS_TARGET']] = 1
NO_PGO = True # Don't PGO
if CONFIG['CC_TYPE'] in ('clang', 'gcc'): if CONFIG['CC_TYPE'] in ('clang', 'gcc'):
CXXFLAGS += ['-Wno-error=shadow'] CXXFLAGS += ['-Wno-error=shadow']

View File

@ -86,7 +86,5 @@ if CONFIG['OS_TARGET'] == 'OpenBSD':
if CONFIG['OS_TARGET'] == 'DragonFly': if CONFIG['OS_TARGET'] == 'DragonFly':
DEFINES['__DragonFly__'] = False DEFINES['__DragonFly__'] = False
NO_PGO = True # Don't PGO
if CONFIG['CC_TYPE'] in ('clang', 'gcc'): if CONFIG['CC_TYPE'] in ('clang', 'gcc'):
CFLAGS += ['-std=gnu99'] CFLAGS += ['-std=gnu99']

View File

@ -332,5 +332,3 @@ LOCAL_INCLUDES += [
'../..', '../..',
'/xpcom/reflect/xptinfo', '/xpcom/reflect/xptinfo',
] ]
NO_PGO = True

View File

@ -34,7 +34,6 @@ else:
'xptcinvoke_asm_x86_msvc.asm', 'xptcinvoke_asm_x86_msvc.asm',
'xptcstubs.cpp', 'xptcstubs.cpp',
] ]
SOURCES['xptcinvoke.cpp'].no_pgo = True
SOURCES['xptcinvoke_asm_x86_msvc.asm'].flags += ['-safeseh'] SOURCES['xptcinvoke_asm_x86_msvc.asm'].flags += ['-safeseh']
FINAL_LIBRARY = 'xul' FINAL_LIBRARY = 'xul'