Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-01-26 06:38:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Backed out 2 changesets (bug 1416620) for failing own reftest. r=backout a=backout on a CLOSED TREE

Browse Source 
Backed out changeset 3b45218edc2e (bug 1416620)
Backed out changeset c48580e1f535 (bug 1416620)
This commit is contained in:
Sebastian Hengst 2017-11-14 13:04:52 +02:00
parent 5d394948fa
commit 53f71049ff
4 changed files with 11 additions and 75 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
gfx/tests/reftest/1416620-1-ref.html
View File

@ -1,31 +0,0 @@
<!DOCTYPE HTML>
<html>
<head>
<meta charset="utf-8">
<title>Testcase for bug 1416620</title>
<style>
#a, #b {
width: 100px;
height: 100px;
background-color: green;
-moz-appearance: none;
box-shadow: inset 4px 4px 30px black;
border: none;
position: absolute;
}
#a {
top: 20px;
left: 20px;
}
#b {
top: 170px;
left: 20px;
</style>
</head>
<body>
<div id="a">&nbsp;</div>
<div id="b">&nbsp;</div>
</body>
</html>

32
gfx/tests/reftest/1416620-1.html
View File

@ -1,32 +0,0 @@
<!DOCTYPE HTML>
<html>
<head>
<meta charset="utf-8">
<title>Testcase for bug 1416620</title>
<style>
#a, #b {
width: 100px;
height: 100px;
background-color: green;
box-shadow: inset 4px 4px 30px black;
border-style: solid;
border-width: 0;
border-color: red;
position: absolute;
}
#a {
top: 20px;
left: 20px;
}
#b {
top: 170px;
left: 20px;
</style>
</head>
<body>
<input type="button" id="a" value=""></input>
<button id="b"></button>
</body>
</html>

1
gfx/tests/reftest/reftest.list
View File

@ -7,4 +7,3 @@ skip-if(!asyncPan) == 1086723.html 1086723-ref.html
skip-if(Android) fuzzy-if(skiaContent,1,587) == 1143303-1.svg pass.svg
fuzzy(100,30) == 1149923.html 1149923-ref.html # use fuzzy due to few distorted pixels caused by border-radius
== 1131264-1.svg pass.svg
== 1416620-1.html 1416620-1-ref.html

22
layout/forms/nsButtonFrameRenderer.cpp
View File

@ -293,17 +293,6 @@ nsDisplayButtonBorder::CreateWebRenderCommands(mozilla::wr::DisplayListBuilder&
mozilla::layers::WebRenderLayerManager* aManager,
nsDisplayListBuilder* aDisplayListBuilder)
{
// This is really a combination of paint box shadow inner +
// paint border.
nsRect buttonRect = nsRect(ToReferenceFrame(), mFrame->GetSize());
bool snap;
nsRegion visible = GetBounds(aDisplayListBuilder, &snap);
nsDisplayBoxShadowInner::CreateInsetBoxShadowWebRenderCommands(aBuilder,
aSc,
visible,
mFrame,
buttonRect);
bool borderIsEmpty = false;
Maybe<nsCSSBorderRenderer> br =
nsCSSRendering::CreateBorderRenderer(mFrame->PresContext(),
@ -324,6 +313,17 @@ nsDisplayButtonBorder::CreateWebRenderCommands(mozilla::wr::DisplayListBuilder&
return false;
}
// This is really a combination of paint box shadow inner +
// paint border.
nsRect buttonRect = nsRect(ToReferenceFrame(), mFrame->GetSize());
bool snap;
nsRegion visible = GetBounds(aDisplayListBuilder, &snap);
nsDisplayBoxShadowInner::CreateInsetBoxShadowWebRenderCommands(aBuilder,
aSc,
visible,
mFrame,
buttonRect);
br->CreateWebRenderCommands(this, aBuilder, aResources, aSc);
return true;