Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-24 21:31:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1552818 - part2 : refactor test 'test_audioNotificationNavigationWebAudio.html' by using async-await form. r=padenot

Browse Source 
Using async and await form can increase the readability of the test.

Differential Revision: https://phabricator.services.mozilla.com/D36535

--HG--
extra : moz-landing-system : lando
This commit is contained in:
alwu 2019-07-02 12:05:55 +00:00
parent cab800b094
commit 54909f9858
1 changed files with 56 additions and 52 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

108
dom/base/test/test_audioNotificationNavigationWebAudio.html
View File

@ -6,74 +6,78 @@
<link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
</head>
<body>
<pre id="test">
</pre>
<iframe></iframe>
<script type="application/javascript">
/**
* This test is used to ensure that the `audio-playback` notification would be
* dispatched correctly when we start playing web audio from a iframe.
*/
var expectedNotifications = null;
const iframe = document.querySelector("iframe");
SimpleTest.waitForExplicitFinish();
async function startTest() {
addObserver();
await startLoadingWebAudioInIframe();
await reloadIFrame();
cleanUpTestAndRemoveObserver();
}
var expectedNotification = null;
var iframe = null;
var observer = {
const observer = {
observe: function(subject, topic, data) {
is(topic, "audio-playback", "audio-playback received");
var expected = expectedNotification.shift();
const expected = expectedNotifications.shift();
is(data, expected, `"${data}" is the right notification`);
if (expectedNotification.length == 0) {
runTest();
if (expectedNotifications.length == 0) {
this.resolve();
}
},
wait() {
return new Promise((resolve) => {
info(`Waiting for the notification "${expectedNotifications[0]}"`);
this.resolve = resolve;
});
}
};
var observerService = SpecialPowers.Cc["@mozilla.org/observer-service;1"]
const observerService = SpecialPowers.Cc["@mozilla.org/observer-service;1"]
.getService(SpecialPowers.Ci.nsIObserverService);
SimpleTest.waitForExplicitFinish();
onload = startTest;
var tests = [
function() {
iframe = document.querySelector("iframe");
observerService.addObserver(observer, "audio-playback");
ok(true, "Observer set");
runTest();
},
function() {
info("Load iframe");
expectedNotification = ["active"];
iframe.src = "file_webAudioAudible.html";
},
function() {
info("Reload iframe");
// As reloading frame would stop previous audio playing in frame, we would
// receive "inactive-pause" first.
expectedNotification = ["inactive-pause", "active"];
iframe.src = "file_webAudioAudible.html";
},
function() {
info("Cleaning up iframe");
expectedNotification = ["inactive-pause"];
iframe.src = null;
}
];
function runTest() {
if (!tests.length) {
observerService.removeObserver(observer, "audio-playback");
ok(true, "Observer removed");
SimpleTest.finish();
return;
}
var test = tests.shift();
test();
/**
* The following are test helper functions.
*/
function addObserver() {
observerService.addObserver(observer, "audio-playback");
ok(true, "Observer set");
}
onload = runTest;
async function startLoadingWebAudioInIframe() {
info("Load iframe");
expectedNotifications = ["active"];
iframe.src = "file_webAudioAudible.html";
await observer.wait();
}
async function reloadIFrame() {
info("Reload iframe");
// As reloading frame would stop previous audio playing in frame, we would
// receive "inactive-pause" first.
expectedNotifications = ["inactive-pause", "active"];
iframe.src = "file_webAudioAudible.html";
await observer.wait();
}
async function cleanUpTestAndRemoveObserver() {
info("Cleaning up iframe");
expectedNotifications = ["inactive-pause"];
iframe.src = null;
await observer.wait();
observerService.removeObserver(observer, "audio-playback");
ok(true, "Observer removed");
SimpleTest.finish();
}
</script>
</body>
</html>