Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-08 02:14:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1659187 - [taskgraph] Move optimization reason logging to the _log_optimizations function, r=taskgraph-reviewers,aki

Browse Source 
This is needed as future revisions will refactor the optimization process to be
two pass. So we can't be sure if a task is optimized or not until the very end.

Depends on D87771

Differential Revision: https://phabricator.services.mozilla.com/D87772
This commit is contained in:
Andrew Halberstadt 2020-08-20 16:39:19 +00:00
parent cf9986de30
commit 54dac3bfb2
1 changed files with 14 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
taskcluster/taskgraph/optimize/__init__.py
View File

@ -91,7 +91,12 @@ def _get_optimizations(target_task_graph, strategies):
return optimizations
def _log_optimization(verb, opt_counts):
def _log_optimization(verb, opt_counts, opt_reasons=None):
if opt_reasons:
message = "optimize: {label} {action} because of {reason}"
for label, (action, reason) in opt_reasons.items():
logger.debug(message.format(label=label, action=action, reason=reason))
if opt_counts:
logger.info(
'{} '.format(verb.title()) +
@ -108,44 +113,37 @@ def remove_tasks(target_task_graph, requested_tasks, params, optimizations, do_n
Implement the "Removing Tasks" phase, returning a set of task labels of all removed tasks.
"""
opt_counts = defaultdict(int)
opt_reasons = {}
removed = set()
reverse_links_dict = target_task_graph.graph.reverse_links_dict()
message = "optimize: {label} {verb} because of {reason}"
for label in target_task_graph.graph.visit_preorder():
verb = "kept"
# if we're not allowed to optimize, that's easy..
if label in do_not_optimize:
logger.debug(message.format(label=label, verb=verb, reason="do not optimize"))
opt_reasons[label] = ("kept", "do not optimize")
continue
# if there are remaining tasks depending on this one, do not remove..
if any(l not in removed for l in reverse_links_dict[label]):
logger.debug(message.format(label=label, verb=verb, reason="dependent tasks"))
opt_reasons[label] = ("kept", "dependent tasks")
continue
# Some tasks in the task graph only exist because they were required
# by a task that has just been optimized away. They can now be removed.
if label not in requested_tasks:
reason = "downstreams-optimized"
verb = "removed"
opt_counts['dependents-optimized'] += 1
opt_reasons[label] = ("removed", "dependents optimized")
removed.add(label)
opt_counts['downstreams-optimized'] += 1
logger.debug(message.format(label=label, verb=verb, reason=reason))
# call the optimization strategy
task = target_task_graph.tasks[label]
opt_by, opt, arg = optimizations(label)
if opt.should_remove_task(task, params, arg):
verb = "removed"
removed.add(label)
opt_counts[opt_by] += 1
opt_reasons[label] = ("removed", "'{}' strategy".format(opt_by))
removed.add(label)
reason = "'{}' strategy".format(opt_by)
logger.debug(message.format(label=label, verb=verb, reason=reason))
_log_optimization('removed', opt_counts)
_log_optimization('removed', opt_counts, opt_reasons)
return removed