Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-10 17:24:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 631352. Changes to @lang need to restyle all descendants. r=dbaron, a=blocker

Browse Source
This commit is contained in:
Boris Zbarsky 2011-02-08 16:30:57 -05:00
parent 29c337dec4
commit 5579a836d1
4 changed files with 26 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
layout/reftests/bugs/631352-1-ref.html Normal file
View File

@ -0,0 +1,6 @@
<!DOCTYPE html>
<html>
<body>
<div>This text should be visible</div>
</body>
</html>

11
layout/reftests/bugs/631352-1.html Normal file
View File

@ -0,0 +1,11 @@
<!DOCTYPE html>
<html>
<head>
<style>
div:not(:lang(foo)) { display: none; }
</style>
</head>
<body onload="document.body.offsetWidth; document.body.lang = 'foo'">
<div>This text should be visible</div>
</body>
</html>

1
layout/reftests/bugs/reftest.list
View File

@ -1609,3 +1609,4 @@ random-if(winWidget) == 621918-1.svg 621918-1-ref.svg # 1-pixel diacritic positi
random-if(winWidget) HTTP(..) == 621918-2.svg 621918-2-ref.svg # same 1px issue as above, and HTTP(..) for filters.svg, used to mask antialiasing issues where glyphs touch random-if(winWidget) HTTP(..) == 621918-2.svg 621918-2-ref.svg # same 1px issue as above, and HTTP(..) for filters.svg, used to mask antialiasing issues where glyphs touch
== 625409-1.html 625409-1-ref.html == 625409-1.html 625409-1-ref.html
== 627393-1.html about:blank == 627393-1.html about:blank
== 631352-1.html 631352-1-ref.html

8
layout/style/nsCSSRuleProcessor.cpp
View File

@ -2573,6 +2573,14 @@ nsCSSRuleProcessor::HasAttributeDependentStyle(AttributeRuleProcessorData* aData
{ {
data.change = nsRestyleHint(data.change | eRestyle_Subtree); data.change = nsRestyleHint(data.change | eRestyle_Subtree);
} }
// We don't know the namespace of the attribute, and xml:lang applies to
// all elements. If the lang attribute changes, we need to restyle our
// whole subtree, since the :lang selector on our descendants can examine
// our lang attribute.
if (aData->mAttribute == nsGkAtoms::lang) {
data.change = nsRestyleHint(data.change | eRestyle_Subtree);
}
} }
RuleCascadeData* cascade = GetRuleCascade(aData->mPresContext); RuleCascadeData* cascade = GetRuleCascade(aData->mPresContext);