Bug 1539779 - clang-tidy 8 mixes stderr and stdout causing parsing issues. r=sylvestre

Reviewers: sylvestre

Reviewed By: sylvestre

Bug #: 1539779

Differential Revision: https://phabricator.services.mozilla.com/D25255

--HG--
extra : rebase_source : 83da546c3121350a7560a6890ad2c5920c1df613
extra : histedit_source : 6f1f945e7cfda0cb87f26c679fa2cfe78bde1e5e

build/build-clang/clang-tidy-8.patch

@@ -0,0 +1,10 @@
+--- a/extra/clang-tidy/tool/run-clang-tidy.py	2019-03-27 15:12:48.000000000 +0200
++++ b/extra/clang-tidy/tool/run-clang-tidy.py	2019-03-27 15:12:39.000000000 +0200
+@@ -169,6 +169,7 @@
+     with lock:
+       sys.stdout.write(' '.join(invocation) + '\n' + output.decode('utf-8') + '\n')
+       if len(err) > 0:
++        sys.stdout.flush()
+         sys.stderr.write(err.decode('utf-8') + '\n')
+     queue.task_done()
+ 

build/build-clang/clang-tidy-linux64.json

@@ -16,5 +16,6 @@
     "cxx": "/builds/worker/workspace/build/src/gcc/bin/g++",
     "as": "/builds/worker/workspace/build/src/gcc/bin/gcc",
     "patches": [
+      "clang-tidy-8.patch"
     ]
 }

build/build-clang/clang-tidy-macosx64.json

@@ -21,5 +21,6 @@
     "libtool": "/builds/worker/workspace/build/src/cctools/bin/x86_64-darwin11-libtool",
     "ld": "/builds/worker/workspace/build/src/clang/bin/clang",
     "patches": [
+      "clang-tidy-8.patch"
     ]
 }

build/build-clang/clang-tidy-win64.json

@@ -15,5 +15,6 @@
     "cxx": "cl.exe",
     "ml": "ml64.exe",
     "patches": [
+      "clang-tidy-8.patch"
     ]
 }