Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-20 08:45:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1616709 - Pass SourceRefs by const-reference where possible r=djvj

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D63530

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Matthew Gaudet 2020-02-20 20:08:40 +00:00
parent 45e67578d0
commit 55c0a549bd
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
js/src/vm/JSScript.cpp
View File

@ -4304,7 +4304,7 @@ void PrivateScriptData::trace(JSTracer* trc) {
/* static */
JSScript* JSScript::New(JSContext* cx, HandleObject functionOrGlobal,
HandleScriptSourceObject sourceObject,
SourceExtent extent) {
const SourceExtent& extent) {
void* script = Allocate<BaseScript>(cx);
if (!script) {
return nullptr;
@ -4335,7 +4335,7 @@ static bool ShouldTrackRecordReplayProgress(JSScript* script) {
JSScript* JSScript::Create(JSContext* cx, HandleObject functionOrGlobal,
const ReadOnlyCompileOptions& options,
HandleScriptSourceObject sourceObject,
SourceExtent extent) {
const SourceExtent& extent) {
RootedScript script(
cx, JSScript::New(cx, functionOrGlobal, sourceObject, extent));
if (!script) {
@ -5493,7 +5493,7 @@ void LazyScript::initScript(JSScript* script) {
LazyScript* LazyScript::CreateRaw(JSContext* cx, uint32_t ngcthings,
HandleFunction fun,
HandleScriptSourceObject sourceObject,
SourceExtent extent) {
const SourceExtent& extent) {
cx->check(fun);
void* res = Allocate<BaseScript>(cx);
@ -5538,7 +5538,7 @@ LazyScript* LazyScript::Create(
JSContext* cx, HandleFunction fun, HandleScriptSourceObject sourceObject,
const frontend::AtomVector& closedOverBindings,
const frontend::FunctionBoxVector& innerFunctionBoxes,
SourceExtent extent) {
const SourceExtent& extent) {
uint32_t ngcthings =
innerFunctionBoxes.length() + closedOverBindings.length();

8
js/src/vm/JSScript.h
View File

@ -2649,13 +2649,13 @@ class JSScript : public js::BaseScript {
static JSScript* New(JSContext* cx, js::HandleObject functionOrGlobal,
js::HandleScriptSourceObject sourceObject,
js::SourceExtent extent);
const js::SourceExtent& extent);
public:
static JSScript* Create(JSContext* cx, js::HandleObject functionOrGlobal,
const JS::ReadOnlyCompileOptions& options,
js::HandleScriptSourceObject sourceObject,
js::SourceExtent extent);
const js::SourceExtent& extent);
static JSScript* CreateFromLazy(JSContext* cx,
js::Handle<js::LazyScript*> lazy);
@ -3340,7 +3340,7 @@ class LazyScript : public BaseScript {
static LazyScript* CreateRaw(JSContext* cx, uint32_t ngcthings,
HandleFunction fun,
HandleScriptSourceObject sourceObject,
SourceExtent extent);
const SourceExtent& extent);
public:
static const uint32_t NumClosedOverBindingsLimit =
@ -3353,7 +3353,7 @@ class LazyScript : public BaseScript {
JSContext* cx, HandleFunction fun, HandleScriptSourceObject sourceObject,
const frontend::AtomVector& closedOverBindings,
const frontend::FunctionBoxVector& innerFunctionBoxes,
SourceExtent extent);
const SourceExtent& extent);
// Create a LazyScript and initialize the closedOverBindings and the
// innerFunctions with dummy values to be replaced in a later initialization