Bug 1603366 - Rename Omniscient browser toolbox to Multiprocess Browser Toolbox and support localization r=pbro,flod

Differential Revision: https://phabricator.services.mozilla.com/D56877

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Julian Descottes 2019-12-12 15:00:20 +00:00
parent b9e29077e8
commit 55cb60a6e3
10 changed files with 32 additions and 14 deletions

View File

@ -2,8 +2,8 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
// Test that the debugger pauses in the omniscient browser toolbox even when it
// hasn't been opened.
// Test that the debugger pauses in the multiprocess browser toolbox even when
// it hasn't been opened.
"use strict";

View File

@ -2,7 +2,7 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
// Test that all kinds of workers show up properly in the omniscient browser
// Test that all kinds of workers show up properly in the multiprocess browser
// toolbox.
"use strict";

View File

@ -22,7 +22,7 @@ const PREFERENCES = [
],
[
"devtools.browsertoolbox.fission",
"Enable the Omniscient Browser Toolbox and Omniscient Browser " +
"Enable the Multiprocess Browser Toolbox and Multiprocess Browser " +
"Console, so that it can see and debug resources from the content " +
"processes at the same time as resources from the parent process",
],
@ -30,7 +30,7 @@ const PREFERENCES = [
"devtools.inspector.use-new-box-model-highlighter",
"Enables a new highlighter implementation that can simultaneously " +
"highlight content in the parent and content processes. This allows to " +
"use a single highlighter in the Omniscient Browser Toolbox.",
"use a single highlighter in the Multiprocess Browser Toolbox.",
],
[
"devtools.target-switching.enabled",

View File

@ -459,11 +459,11 @@ OptionsPanel.prototype = {
];
// In the Nightly Browser Toolbox, display an option to enable the experimental
// Omniscient Browser Toolbox.
// Multiprocess Browser Toolbox.
if (this.target.isParentProcess) {
prefDefinitions.push({
pref: "devtools.browsertoolbox.fission",
label: "Enable Omniscient Browser Toolbox (⚠ WIP ⚠, needs restart)",
label: L10N.getStr("options.enableMultiProcessToolbox"),
id: "devtools-browsertoolbox-fission",
parentId: "context-options",
});

View File

@ -2980,12 +2980,12 @@ Toolbox.prototype = {
_refreshHostTitle: function() {
let title;
const isOmniscientBrowserToolbox =
const isMultiProcessBrowserToolbox =
this.target.isParentProcess &&
Services.prefs.getBoolPref("devtools.browsertoolbox.fission", false);
if (isOmniscientBrowserToolbox) {
title = "💥 Omniscient Browser Toolbox 💥";
if (isMultiProcessBrowserToolbox) {
title = L10N.getStr("toolbox.multiProcessBrowserToolboxTitle");
} else if (this.target.name && this.target.name != this.target.url) {
const url = this.target.isWebExtension
? this.target.getExtensionPathName(this.target.url)

View File

@ -13,6 +13,12 @@ toolbox.titleTemplate1=Developer Tools - %1$S
# The URL of the page being targeted: %2$S.
toolbox.titleTemplate2=Developer Tools - %1$S - %2$S
# LOCALIZATION NOTE (toolbox.multiProcessBrowserToolboxTitle): Title used for
# the Browser Toolbox when the pref `devtools.browsertoolbox.fission` is true.
# This Browser Toolbox allows to debug the parent process as well as the content
# processes in the same toolbox.
toolbox.multiProcessBrowserToolboxTitle=Multiprocess Browser Toolbox
# LOCALIZATION NOTE (toolbox.defaultTitle): This is used as the tool
# name when no tool is selected.
toolbox.defaultTitle=Developer Tools
@ -274,3 +280,7 @@ options.deprecationNotice=Deprecated. Learn More…
# settings panel for the checkbox that enables Replay.
# This entire text is treated as a link to an MDN page.
options.experimentalNotice=Experimental. Learn More…
# LOCALIZATION NOTE (options.enableMultiProcessToolbox): This is the text that appears in the
# settings panel for the checkbox that enables the Multiprocess Browser Toolbox.
options.enableMultiProcessToolbox=Enable the Multiprocess Browser Toolbox (requires restarting the Browser Toolbox)

View File

@ -7,9 +7,17 @@
# You want to make that choice consistent across the developer tools.
# A good criteria is the language in which you'd find the best
# documentation on web development on the web.
# LOCALIZATION NOTE (browserConsole.title): shown as the
# title when opening the browser console popup
browserConsole.title=Browser Console
# LOCALIZATION NOTE (multiProcessBrowserConsole.title): Title of the Browser
# Console window when the pref `devtools.browsertoolbox.fission` is true. This
# Browser Console will log messages from all processes, not just the the parent
# process.
multiProcessBrowserConsole.title=Multiprocess Browser Console
# LOCALIZATION NOTE (timestampFormat): %1$02S = hours (24-hour clock),
# %2$02S = minutes, %3$02S = seconds, %4$03S = milliseconds.
timestampFormat=%02S:%02S:%02S.%03S

View File

@ -163,7 +163,7 @@ class BrowserConsoleManager {
PREFS.FEATURES.BROWSER_TOOLBOX_FISSION
);
const title = fissionSupport
? `💥 Fission Browser Console 💥`
? l10n.getStr("multiProcessBrowserConsole.title")
: l10n.getStr("browserConsole.title");
win.document.title = title;
return win;

View File

@ -2,8 +2,8 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
// Test that when the omniscient browser toolbox is used, console messages from
// newly opened content processes appear.
// Test that when the multiprocess browser toolbox is used, console messages
// from newly opened content processes appear.
"use strict";

View File

@ -182,7 +182,7 @@ class InspectorFront extends FrontClassWithSpec(inspectorSpec) {
}
// If the contentDomReference has a different browsing context than the current one,
// we are either in Fission or in the Omniscient Browser Toolbox, so we need to
// we are either in Fission or in the Multiprocess Browser Toolbox, so we need to
// retrieve the walker of the BrowsingContextTarget.
const descriptor = await this.targetFront.client.mainRoot.getBrowsingContextDescriptor(
browsingContextId