Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-28 15:23:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Backed out changeset eaeaf7286193 (bug 1748643) for causing mochitest failures on test_midi_permission_gated.html. CLOSED TREE

Browse Source
This commit is contained in:
Iulian Moraru 2022-02-12 01:08:29 +02:00
parent 912854cac5
commit 562713e6bd
3 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dom/midi/midirMIDIPlatformService.cpp
View File

@ -35,10 +35,6 @@ class SendRunnable : public MIDIBackgroundRunnable {
~SendRunnable() = default;
virtual void RunInternal() {
AssertIsOnBackgroundThread();
if (!MIDIPlatformService::IsRunning()) {
// Some send operations might outlive the service, bail out and do nothing
return;
}
midirMIDIPlatformService* srv =
static_cast<midirMIDIPlatformService*>(MIDIPlatformService::Get());
srv->SendMessage(mPortID, mMessage);

2
dom/midi/midir_impl/src/lib.rs
View File

@ -159,7 +159,7 @@ impl MidirWrapper {
fn send(self: &mut MidirWrapper, id: &str, data: &[u8]) -> Result<(), ()> {
let connections = &mut self.connections;
let index = connections.iter().position(|e| e.id.eq(id)).ok_or(())?;
let index = connections.iter().position(|e| e.id.eq(id)).unwrap();
let connection_wrapper = connections.get_mut(index).unwrap();
match &mut connection_wrapper.connection {

2
dom/midi/tests/mochitest.ini
View File

@ -8,7 +8,7 @@ scheme = https
[test_midi_permission_allow.html]
[test_midi_permission_deny.html]
[test_midi_permission_gated.html]
skip-if = os == 'android'
skip-if = os == 'android' || os == 'linux' || os == 'mac' #Bug 1747637
[test_midi_device_enumeration.html]
[test_midi_device_implicit_open_close.html]
[test_midi_device_explicit_open_close.html]