Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-28 20:55:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1036574 - Revert horrible workaround in baseline IC for magic arg callee. (r=me)

Browse Source
This commit is contained in:
Shu-yu Guo 2015-08-07 15:14:04 -07:00
parent 741dbc133e
commit 5683b4cc23
1 changed files with 2 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
js/src/jit/BaselineIC.cpp
View File

@ -6572,20 +6572,8 @@ TryAttachMagicArgumentsGetPropStub(JSContext* cx, JSScript* script, ICGetProp_Fa
// Unlike ICGetProp_ArgumentsLength, only magic argument stubs are
// supported at the moment.
ICStub* monitorStub = stub->fallbackMonitorStub()->firstMonitorStub();
// XXXshu the compiler really should be stack allocated, but stack
// allocating it causes the test_temporary_storage indexedDB test to
// fail on GCC 4.7-compiled ARMv6 optimized builds on Android 2.3 and
// below with a NotFoundError, despite that test never exercising this
// code.
//
// Instead of tracking down the GCC bug, I've opted to heap allocate
// instead.
ScopedJSDeletePtr<ICGetProp_ArgumentsCallee::Compiler> compiler;
compiler = js_new<ICGetProp_ArgumentsCallee::Compiler>(cx, monitorStub);
if (!compiler)
return false;
ICStub* newStub = compiler->getStub(compiler->getStubSpace(script));
ICGetProp_ArgumentsCallee::Compiler compiler(cx, monitorStub);
ICStub* newStub = compiler.getStub(compiler.getStubSpace(script));
if (!newStub)
return false;
stub->addNewStub(newStub);