diff --git a/gfx/layers/BufferTexture.h b/gfx/layers/BufferTexture.h index 91c6b90459a9..2999d1d944be 100644 --- a/gfx/layers/BufferTexture.h +++ b/gfx/layers/BufferTexture.h @@ -43,7 +43,7 @@ public: YUVColorSpace aYUVColorSpace, TextureFlags aTextureFlags); - virtual bool Lock(OpenMode aMode, FenceHandle*) override { return true; } + virtual bool Lock(OpenMode aMode) override { return true; } virtual void Unlock() override {} diff --git a/gfx/layers/TextureDIB.h b/gfx/layers/TextureDIB.h index eb34d387bf5d..7eed7e58c180 100644 --- a/gfx/layers/TextureDIB.h +++ b/gfx/layers/TextureDIB.h @@ -18,7 +18,7 @@ namespace layers { class DIBTextureData : public TextureData { public: - virtual bool Lock(OpenMode, FenceHandle*) override { return true; } + virtual bool Lock(OpenMode) override { return true; } virtual void Unlock() override {} diff --git a/gfx/layers/basic/TextureClientX11.cpp b/gfx/layers/basic/TextureClientX11.cpp index 2635229255b3..c79ab1a539ae 100644 --- a/gfx/layers/basic/TextureClientX11.cpp +++ b/gfx/layers/basic/TextureClientX11.cpp @@ -34,7 +34,7 @@ X11TextureData::X11TextureData(gfx::IntSize aSize, gfx::SurfaceFormat aFormat, } bool -X11TextureData::Lock(OpenMode aMode, FenceHandle*) +X11TextureData::Lock(OpenMode aMode) { return true; } diff --git a/gfx/layers/basic/TextureClientX11.h b/gfx/layers/basic/TextureClientX11.h index d83673209b93..084538ea165d 100644 --- a/gfx/layers/basic/TextureClientX11.h +++ b/gfx/layers/basic/TextureClientX11.h @@ -21,7 +21,7 @@ public: virtual bool Serialize(SurfaceDescriptor& aOutDescriptor) override; - virtual bool Lock(OpenMode aMode, FenceHandle*) override; + virtual bool Lock(OpenMode aMode) override; virtual void Unlock() override; diff --git a/gfx/layers/client/GPUVideoTextureClient.h b/gfx/layers/client/GPUVideoTextureClient.h index 552f4782758a..fbad4c68e94e 100644 --- a/gfx/layers/client/GPUVideoTextureClient.h +++ b/gfx/layers/client/GPUVideoTextureClient.h @@ -24,7 +24,7 @@ public: virtual void FillInfo(TextureData::Info& aInfo) const override; - virtual bool Lock(OpenMode, FenceHandle*) override { return true; }; + virtual bool Lock(OpenMode) override { return true; }; virtual void Unlock() override {}; diff --git a/gfx/layers/client/TextureClient.cpp b/gfx/layers/client/TextureClient.cpp index 35270abfc703..61132670d01f 100644 --- a/gfx/layers/client/TextureClient.cpp +++ b/gfx/layers/client/TextureClient.cpp @@ -498,8 +498,7 @@ TextureClient::Lock(OpenMode aMode) LockActor(); - FenceHandle* fence = (mReleaseFenceHandle.IsValid() && (aMode & OpenMode::OPEN_WRITE)) ? &mReleaseFenceHandle : nullptr; - mIsLocked = mData->Lock(aMode, fence); + mIsLocked = mData->Lock(aMode); mOpenMode = aMode; auto format = GetFormat(); diff --git a/gfx/layers/client/TextureClient.h b/gfx/layers/client/TextureClient.h index b28a633c558e..d2ee5bcd3350 100644 --- a/gfx/layers/client/TextureClient.h +++ b/gfx/layers/client/TextureClient.h @@ -260,7 +260,7 @@ public: virtual void FillInfo(TextureData::Info& aInfo) const = 0; - virtual bool Lock(OpenMode aMode, FenceHandle* aFence) = 0; + virtual bool Lock(OpenMode aMode) = 0; virtual void Unlock() = 0; @@ -583,18 +583,6 @@ public: */ void Destroy(bool sync = false); - virtual void SetReleaseFenceHandle(const FenceHandle& aReleaseFenceHandle) - { - mReleaseFenceHandle.Merge(aReleaseFenceHandle); - } - - virtual FenceHandle GetAndResetReleaseFenceHandle() - { - FenceHandle fence; - mReleaseFenceHandle.TransferToAnotherFenceHandle(fence); - return fence; - } - /** * Track how much of this texture is wasted. * For example we might allocate a 256x256 tile but only use 10x10. @@ -722,7 +710,6 @@ protected: RefPtr mBorrowedDrawTarget; TextureFlags mFlags; - FenceHandle mReleaseFenceHandle; gl::GfxTextureWasteTracker mWasteTracker; diff --git a/gfx/layers/client/TextureClientSharedSurface.h b/gfx/layers/client/TextureClientSharedSurface.h index 95deb759b916..cfe5085f890f 100644 --- a/gfx/layers/client/TextureClientSharedSurface.h +++ b/gfx/layers/client/TextureClientSharedSurface.h @@ -40,7 +40,7 @@ public: ~SharedSurfaceTextureData(); - virtual bool Lock(OpenMode, FenceHandle*) override { return false; } + virtual bool Lock(OpenMode) override { return false; } virtual void Unlock() override {} diff --git a/gfx/layers/d3d11/TextureD3D11.cpp b/gfx/layers/d3d11/TextureD3D11.cpp index aae0707e4f95..aca8ad67742a 100644 --- a/gfx/layers/d3d11/TextureD3D11.cpp +++ b/gfx/layers/d3d11/TextureD3D11.cpp @@ -249,7 +249,7 @@ D3D11TextureData::~D3D11TextureData() // when it calls EndDraw. This EndDraw should not execute anything so it // shouldn't -really- need the lock but the debug layer chokes on this. if (mDrawTarget) { - Lock(OpenMode::OPEN_NONE, nullptr); + Lock(OpenMode::OPEN_NONE); mDrawTarget = nullptr; Unlock(); } @@ -257,7 +257,7 @@ D3D11TextureData::~D3D11TextureData() } bool -D3D11TextureData::Lock(OpenMode aMode, FenceHandle*) +D3D11TextureData::Lock(OpenMode aMode) { if (!LockD3DTexture(mTexture.get())) { return false; diff --git a/gfx/layers/d3d11/TextureD3D11.h b/gfx/layers/d3d11/TextureD3D11.h index e36f9ed784a3..e97d7be6f82b 100644 --- a/gfx/layers/d3d11/TextureD3D11.h +++ b/gfx/layers/d3d11/TextureD3D11.h @@ -65,7 +65,7 @@ public: virtual bool UpdateFromSurface(gfx::SourceSurface* aSurface) override; - virtual bool Lock(OpenMode aMode, FenceHandle*) override; + virtual bool Lock(OpenMode aMode) override; virtual void Unlock() override; @@ -77,7 +77,6 @@ public: TextureFlags aFlags, TextureAllocationFlags aAllocFlags) const override; - // TODO - merge this with the FenceHandle API! virtual void SyncWithObject(SyncObject* aSync) override; ID3D11Texture2D* GetD3D11Texture() { return mTexture; } @@ -136,7 +135,7 @@ public: const gfx::IntSize& aSizeY, const gfx::IntSize& aSizeCbCr); - virtual bool Lock(OpenMode, FenceHandle*) override { return true; } + virtual bool Lock(OpenMode) override { return true; } virtual void Unlock() override {} diff --git a/gfx/layers/d3d9/TextureD3D9.cpp b/gfx/layers/d3d9/TextureD3D9.cpp index 2f6f016a3233..fd7f0c024465 100644 --- a/gfx/layers/d3d9/TextureD3D9.cpp +++ b/gfx/layers/d3d9/TextureD3D9.cpp @@ -610,7 +610,7 @@ D3D9TextureData::FillInfo(TextureData::Info& aInfo) const } bool -D3D9TextureData::Lock(OpenMode aMode, FenceHandle*) +D3D9TextureData::Lock(OpenMode aMode) { if (!DeviceManagerD3D9::GetDevice()) { // If the device has failed then we should not lock the surface, diff --git a/gfx/layers/d3d9/TextureD3D9.h b/gfx/layers/d3d9/TextureD3D9.h index 8ed51633c64b..11acc483dabd 100644 --- a/gfx/layers/d3d9/TextureD3D9.h +++ b/gfx/layers/d3d9/TextureD3D9.h @@ -178,7 +178,7 @@ public: virtual bool Serialize(SurfaceDescriptor& aOutDescrptor) override; - virtual bool Lock(OpenMode aMode, FenceHandle*) override; + virtual bool Lock(OpenMode aMode) override; virtual void Unlock() override; @@ -227,7 +227,7 @@ public: virtual void FillInfo(TextureData::Info& aInfo) const override; - virtual bool Lock(OpenMode, FenceHandle*) override { return true; } + virtual bool Lock(OpenMode) override { return true; } virtual void Unlock() override {} diff --git a/gfx/layers/opengl/MacIOSurfaceTextureClientOGL.cpp b/gfx/layers/opengl/MacIOSurfaceTextureClientOGL.cpp index ec62eefbe3ae..dd522e650342 100644 --- a/gfx/layers/opengl/MacIOSurfaceTextureClientOGL.cpp +++ b/gfx/layers/opengl/MacIOSurfaceTextureClientOGL.cpp @@ -76,7 +76,7 @@ MacIOSurfaceTextureData::FillInfo(TextureData::Info& aInfo) const } bool -MacIOSurfaceTextureData::Lock(OpenMode, FenceHandle*) +MacIOSurfaceTextureData::Lock(OpenMode) { mSurface->Lock(false); return true; diff --git a/gfx/layers/opengl/MacIOSurfaceTextureClientOGL.h b/gfx/layers/opengl/MacIOSurfaceTextureClientOGL.h index 175fffa0affe..21e4459537b9 100644 --- a/gfx/layers/opengl/MacIOSurfaceTextureClientOGL.h +++ b/gfx/layers/opengl/MacIOSurfaceTextureClientOGL.h @@ -27,7 +27,7 @@ public: virtual void FillInfo(TextureData::Info& aInfo) const override; - virtual bool Lock(OpenMode, FenceHandle*) override; + virtual bool Lock(OpenMode) override; virtual void Unlock() override; diff --git a/gfx/layers/opengl/TextureClientOGL.h b/gfx/layers/opengl/TextureClientOGL.h index dca1bf9708df..6555f138adda 100644 --- a/gfx/layers/opengl/TextureClientOGL.h +++ b/gfx/layers/opengl/TextureClientOGL.h @@ -37,7 +37,7 @@ public: virtual void Forget(LayersIPCChannel*) override { mImage = nullptr; } // Unused functions. - virtual bool Lock(OpenMode, FenceHandle*) override { return true; } + virtual bool Lock(OpenMode) override { return true; } virtual void Unlock() override {} @@ -67,7 +67,7 @@ public: virtual bool Serialize(SurfaceDescriptor& aOutDescriptor) override; // Useless functions. - virtual bool Lock(OpenMode, FenceHandle*) override { return true; } + virtual bool Lock(OpenMode) override { return true; } virtual void Unlock() override {}