Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-27 04:38:02 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 335297: File handle leak in nsWelcomeDlg::GetReadmeContents. Patch by Ryan Flint <rflint@dslr.net>, r=dveditz, sr=Neil

Browse Source
This commit is contained in:
ajschult%verizon.net 2006-05-20 18:01:19 +00:00
parent c2a2243919
commit 56b62c11cc
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
xpinstall/wizard/unix/src2/nsWelcomeDlg.cpp
View File

@ -266,14 +266,14 @@ nsWelcomeDlg::GetReadmeContents()
DUMP("readme fopen");
// get file length
if (0 != stat(mReadmeFile, &attr)) return NULL;
if (attr.st_size == 0) return NULL;
if (0 != stat(mReadmeFile, &attr)) goto BAIL;
if (attr.st_size == 0) goto BAIL;
DUMP("readme fstat");
// allocate buffer of file length
buflen = sizeof(char) * (attr.st_size + 1);
buf = (char *) malloc(buflen);
if (!buf) return NULL;
if (!buf) goto BAIL;
memset(buf, 0, buflen);
DUMP("readme buf malloc");
@ -282,6 +282,7 @@ nsWelcomeDlg::GetReadmeContents()
XI_IF_FREE(buf);
DUMP("readme fread");
BAIL:
// close file
fclose(fd);
DUMP("readme close");