Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-12 04:45:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1067769 - Part 5: Support setting KeyframeEffect.target webidl interface. r=smaug

Browse Source 
MozReview-Commit-ID: 9494jdI97MT

--HG--
extra : rebase_source : 4c8fa7bfb6502c78a96e1af1e2a6d98d7708d7dd
This commit is contained in:
Boris Chiou 2016-04-28 23:22:43 +08:00
parent bbb222e2a8
commit 57a8894260
3 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
dom/animation/KeyframeEffect.cpp
View File

@ -1372,6 +1372,12 @@ void KeyframeEffect::NotifySpecifiedTimingUpdated()
}
}
void
KeyframeEffect::SetTarget(const Nullable<ElementOrCSSPseudoElement>& aTarget)
{
// TODO: fix in next patch
}
KeyframeEffect::~KeyframeEffect()
{
// mTiming is cycle collected, so we have to do null check first even though

2
dom/animation/KeyframeEffect.h
View File

@ -432,6 +432,8 @@ public:
void NotifySpecifiedTimingUpdated();
void SetTarget(const Nullable<ElementOrCSSPseudoElement>& aTarget);
protected:
~KeyframeEffect() override;
};

3
dom/webidl/KeyframeEffect.webidl
View File

@ -69,8 +69,7 @@ partial interface KeyframeEffectReadOnly {
object? frames,
optional (unrestricted double or KeyframeEffectOptions) options)]
interface KeyframeEffect : KeyframeEffectReadOnly {
// Bug 1067769 - Allow setting KeyframeEffect.target
// inherit attribute Animatable? target;
inherit attribute (Element or CSSPseudoElement)? target;
// Bug 1216843 - implement animation composition
// inherit attribute IterationCompositeOperation iterationComposite;
// Bug 1216844 - implement additive animation