From 584e65690abe02adcb81d0a82d0c0ef4f5aa5cc5 Mon Sep 17 00:00:00 2001 From: Javier Fernandez Date: Tue, 6 Mar 2018 18:37:18 +0000 Subject: [PATCH] Bug 1437067 [wpt PR 9400] - [css-align] justfy-items accepts 'legacy' and drops support for 'auto', a=testonly Automatic update from web-platform-tests The syntax of the 'justify-items' property accepts a new 'legacy' value, replacing the 'auto' value which is now parsed as invalid. https://github.com/w3c/csswg-drafts/issues/1318 This change affects also to the 'place-items' shorthand, which doesn't accept 'auto' and, for the time being, neither 'legacy'. Link to the intent-to-ship-and-remove request: https://groups.google.com/a/chromium.org/d/msgid/blink-dev/552753c1-9b2f-bb01-4fed-2ae621f2398e%40igalia.com?utm_medium=email&utm_source=footer Bug: 726147, 726148 Change-Id: I219de66b813d350fe33f00a1d4369bed8e9a2350 Reviewed-on: https://chromium-review.googlesource.com/903162 Commit-Queue: Javier Fernandez Reviewed-by: Christian Biesinger Reviewed-by: Darren Shen Cr-Commit-Position: refs/heads/master@{#535593} wpt-commits: 6d85a3b422cab97d032ad3db47cb741ca364185f wpt-pr: 9400 reapplied-commits: 370e267e160568862f1fd9ec246ab5bb840f586e, fe4514c84e7ad28e46bad5da93381deb99b177f3, 7806af854343c043a2645a4034fdc7812f65daad, 9ddfd21554293dec5a4bf2e5375ae4f3c9f2ded0, 75f63c4d1ebc949647184fd60972fc7b9fd4affb, 1f3a5b496acd2288cc8cf0c32af86cb35157ea4e, 88b42bd5847abac58a62c4d6b33c1509bfce5f3d, 15c2e4c690700c6c115f8afe5e44ded10d943538, c8d461ef1437641ae7d4ea1d21e1e60cd62910b0, a6088a5f48ee299386a84d2f771902267d7355b1, 0634cd8f08ebe0905a9188fb1398c7b5f889c5dc, c8ee4a012dae506ae06bb5b2ad50942b04c1aaaa, c2c352456a4cf62dcc12f851138b04397675a445, b93a8879555d2fa7e7d4e00a275513a3a6338b35, b86e1331cb36634fd33677043b61fc0c1d8485bc, 44ddf14fd3346658c3223f13652073fafbfa48fa, a1a5840a6bb53e305ba02bcbeb215659342d0edb, 7465cb110ae5ec2e2ca73182caf5293f0efc8fd5, aad5349b3458bc3414e274b33fa86a1123901ff2, eca0907980d2769c449894a6277c60c1a306792f, 38626987c0cfd6e715cfcc6f4f1a1209191a03c5, e4a67f7ddcde6cd99348e9104bd7ed07074da44a, bb3c9990840a0fae2afc840b5952d7874785b112, 042d7adef0bdb9dc80e825c3997ace7519477c42, 99f1ea44fc7915b8b7b33bce4732fa8765fd3ac2, b81999f30c1516a70c153de51a0331d14c8faead --- testing/web-platform/meta/MANIFEST.json | 6 +++--- .../place-content-shorthand-004.html | 6 ++++++ .../default-alignment/parse-justify-items-002.html | 14 +++++++------- .../place-items-shorthand-004.html | 13 ++++++++++++- 4 files changed, 28 insertions(+), 11 deletions(-) diff --git a/testing/web-platform/meta/MANIFEST.json b/testing/web-platform/meta/MANIFEST.json index 7b8ec65b0fe1..6df24cd1afdb 100644 --- a/testing/web-platform/meta/MANIFEST.json +++ b/testing/web-platform/meta/MANIFEST.json @@ -475818,7 +475818,7 @@ "testharness" ], "css/css-align/content-distribution/place-content-shorthand-004.html": [ - "5aa5cda5b2b0204bd2deb5c813532f394644b31f", + "17c135945710d209b2e410d36867f6244ac358a0", "testharness" ], "css/css-align/content-distribution/place-content-shorthand-005.html": [ @@ -475866,7 +475866,7 @@ "testharness" ], "css/css-align/default-alignment/parse-justify-items-002.html": [ - "b74652a3770f5bf8b7184748d62a21625f9121b3", + "12902e19304a7f02a52c576f3daf72fd9eb45ff8", "testharness" ], "css/css-align/default-alignment/parse-justify-items-003.html": [ @@ -475898,7 +475898,7 @@ "testharness" ], "css/css-align/default-alignment/place-items-shorthand-004.html": [ - "d4b6346f68b085a297ba5b15a5803258cbf661da", + "51b0eff81deca9f5e056f5db1d49f3e9be80435b", "testharness" ], "css/css-align/default-alignment/place-items-shorthand-005.html": [ diff --git a/testing/web-platform/tests/css/css-align/content-distribution/place-content-shorthand-004.html b/testing/web-platform/tests/css/css-align/content-distribution/place-content-shorthand-004.html index 30f45b686f4d..3f9bd88efb0e 100644 --- a/testing/web-platform/tests/css/css-align/content-distribution/place-content-shorthand-004.html +++ b/testing/web-platform/tests/css/css-align/content-distribution/place-content-shorthand-004.html @@ -47,6 +47,12 @@ checkInvalidValues("start auto") }, "Verify 'auto' values are invalid"); + test(function() { + checkInvalidValues("self-start") + checkInvalidValues("center self-end") + checkInvalidValues("self-end start") + }, "Verify self-position values are invalid"); + test(function() { checkInvalidValues("") }, "Verify empty declaration is invalid"); diff --git a/testing/web-platform/tests/css/css-align/default-alignment/parse-justify-items-002.html b/testing/web-platform/tests/css/css-align/default-alignment/parse-justify-items-002.html index 6ba2c7c2e1ff..1806fa2c72ad 100644 --- a/testing/web-platform/tests/css/css-align/default-alignment/parse-justify-items-002.html +++ b/testing/web-platform/tests/css/css-align/default-alignment/parse-justify-items-002.html @@ -19,39 +19,39 @@ document.body.appendChild(container); test(function() { element = document.createElement("div"); document.body.appendChild(element); - checkValues(element, "justifyItems", "justify-items", "", "legacy"); + checkValues(element, "justifyItems", "justify-items", "", "normal"); }, "Test 'initial' value when nothing is specified"); test(function() { container.style.display = ""; - checkInitialValues(element, "justifyItems", "justify-items", "center", "legacy"); + checkInitialValues(element, "justifyItems", "justify-items", "center", "normal"); }, "Test justify-items: 'initial'"); test(function() { container.style.display = "grid"; - checkInitialValues(element, "justifyItems", "justify-items", "safe start", "legacy"); + checkInitialValues(element, "justifyItems", "justify-items", "safe start", "normal"); }, "Test grid items justify-items: 'initial'"); test(function() { container.style.display = "flex"; - checkInitialValues(element, "justifyItems", "justify-items", "unsafe end", "legacy"); + checkInitialValues(element, "justifyItems", "justify-items", "unsafe end", "normal"); }, "Test flex items justify-items: 'initial'"); test(function() { container.style.display = ""; element.style.position = "absolute"; - checkInitialValues(element, "justifyItems", "justify-items", "start", "legacy"); + checkInitialValues(element, "justifyItems", "justify-items", "start", "normal"); }, "Test absolute positioned elements justify-items: 'initial'"); test(function() { container.style.display = "grid"; element.style.position = "absolute"; - checkInitialValues(element, "justifyItems", "justify-items", "end", "legacy"); + checkInitialValues(element, "justifyItems", "justify-items", "end", "normal"); }, "Test absolute positioned grid items justify-items: 'initial'"); test(function() { container.style.display = "flex"; element.style.position = "absolute"; - checkInitialValues(element, "justifyItems", "justify-items", "end", "legacy"); + checkInitialValues(element, "justifyItems", "justify-items", "end", "normal"); }, "Test absolute positioned flex items justify-items: 'initial'"); diff --git a/testing/web-platform/tests/css/css-align/default-alignment/place-items-shorthand-004.html b/testing/web-platform/tests/css/css-align/default-alignment/place-items-shorthand-004.html index c5d94726f2af..aa3ff30f70fc 100644 --- a/testing/web-platform/tests/css/css-align/default-alignment/place-items-shorthand-004.html +++ b/testing/web-platform/tests/css/css-align/default-alignment/place-items-shorthand-004.html @@ -37,7 +37,18 @@ checkInvalidValues("auto") checkInvalidValues("auto right") checkInvalidValues("auto auto") - }, "Verify 'auto' value is invalid as first longhand value."); + checkInvalidValues("center auto") + }, "Verify 'auto' value is invalid."); + + test(function() { + checkInvalidValues("legacy") + checkInvalidValues("legacy start") + checkInvalidValues("end legacy") + checkInvalidValues("legacy left") + checkInvalidValues("center legacy") + checkInvalidValues("start legacy center") + }, "Verify 'legacy' value is invalid."); + test(function() { checkInvalidValues("")