Bug 1802535 - Remove the leaf feature from profiler arguments of talos and browsertime r=perftest-reviewers,sparky

Previously we had a "leaf" feature but it's been removed in Bug 1571089. It
doesn't break the tests, but it always outputs an error string to the std out
and it might be annoying for our users or it can get in the way of analyzing
other errors. It's good to remove it.

Differential Revision: https://phabricator.services.mozilla.com/D163126
This commit is contained in:
Nazım Can Altınova 2022-11-25 17:56:16 +00:00
parent 3d09f5737a
commit 58530653d6
2 changed files with 9 additions and 10 deletions

View File

@ -6,19 +6,18 @@
from __future__ import absolute_import, division
import json
import os
import re
import sys
from abc import ABCMeta, abstractmethod
from copy import deepcopy
import os
import json
import re
import six
import sys
import mozprocess
from manifestparser.util import evaluate_list_from_string
import six
from benchmark import Benchmark
from logger.logger import RaptorLogger
from manifestparser.util import evaluate_list_from_string
from perftest import Perftest
from results import BrowsertimeResultsHandler
@ -443,7 +442,7 @@ class Browsertime(Perftest):
(
"gecko_profile_features",
"--firefox.geckoProfilerParams.features",
"js,leaf,stackwalk,cpu,screenshots",
"js,stackwalk,cpu,screenshots",
),
(
"gecko_profile_threads",

View File

@ -13,8 +13,8 @@ import tempfile
import zipfile
import mozfile
from mozlog import get_proxy_logger
from mozgeckoprofiler import ProfileSymbolicator, save_gecko_profile
from mozlog import get_proxy_logger
LOG = get_proxy_logger()
@ -39,7 +39,7 @@ class GeckoProfile(object):
gecko_profile_interval = test_config.get("gecko_profile_interval", 1)
gecko_profile_entries = test_config.get("gecko_profile_entries", 1000000)
gecko_profile_features = test_config.get(
"gecko_profile_features", "js,leaf,stackwalk,cpu"
"gecko_profile_features", "js,stackwalk,cpu"
)
gecko_profile_threads = test_config.get(
"gecko_profile_threads", "GeckoMain,Compositor"