Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-14 22:05:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1072959 - Stop crashing in PinSiteDialog when rotating device r=margaret

Browse Source
This commit is contained in:
Mark Finkle 2015-12-31 15:07:56 -05:00
parent c44d10f2d4
commit 58f8b44fe8
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
mobile/android/base/java/org/mozilla/gecko/home/PinSiteDialog.java
View File

@ -12,6 +12,7 @@ import org.mozilla.gecko.db.BrowserContract.URLColumns;
import org.mozilla.gecko.db.BrowserDB.FilterFlags;
import org.mozilla.gecko.util.StringUtils;
import android.app.Dialog;
import android.content.Context;
import android.database.Cursor;
import android.os.Bundle;
@ -27,6 +28,7 @@ import android.view.KeyEvent;
import android.view.LayoutInflater;
import android.view.View;
import android.view.ViewGroup;
import android.view.Window;
import android.view.WindowManager;
import android.widget.AdapterView;
import android.widget.EditText;
@ -128,7 +130,17 @@ class PinSiteDialog extends DialogFragment {
@Override
public void onFocusChange(View v, boolean hasFocus) {
if (hasFocus) {
getDialog().getWindow().setSoftInputMode(WindowManager.LayoutParams.SOFT_INPUT_STATE_ALWAYS_VISIBLE);
// On rotation, the view gets destroyed and we could be in a race to get the dialog
// and window (see bug 1072959).
Dialog dialog = getDialog();
if (dialog == null) {
return;
}
Window window = dialog.getWindow();
if (window == null) {
return;
}
window.setSoftInputMode(WindowManager.LayoutParams.SOFT_INPUT_STATE_ALWAYS_VISIBLE);
}
}
});