Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-19 08:15:31 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1167756 - Switch to openUILink for the Pocket menubar item to avoid using and leaking AppConstants. r=jaws

Browse Source
This commit is contained in:
Matthew Noorenberghe 2015-05-22 14:07:00 -07:00
parent 6154e9adac
commit 598d42d539
2 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
browser/base/content/browser-menubar.inc
View File

@ -400,7 +400,7 @@
#ifndef XP_MACOSX
class="menuitem-iconic"
#endif
oncommand="window.pktUI.openTabWithUrl(Pocket.listURL);"/>
oncommand="openUILink(Pocket.listURL, event);"/>
<menuseparator id="menu_pocketSeparator"/>
<menuitem id="menu_bookmarkThisPage"
command="Browser:AddBookmarkAs"

9
browser/components/pocket/main.js
View File

@ -42,8 +42,6 @@
// TODO : [nice to have] - Immediately save, buffer the actions in a local queue and send (so it works offline, works like our native extensions)
Cu.import("resource://gre/modules/XPCOMUtils.jsm");
XPCOMUtils.defineLazyModuleGetter(this, "AppConstants",
"resource://gre/modules/AppConstants.jsm");
XPCOMUtils.defineLazyModuleGetter(this, "PrivateBrowsingUtils",
"resource://gre/modules/PrivateBrowsingUtils.jsm");
XPCOMUtils.defineLazyModuleGetter(this, "ReaderMode",
@ -624,12 +622,7 @@ var pktUI = (function() {
function openTabWithUrl(url) {
let recentWindow = Services.wm.getMostRecentWindow("navigator:browser");
if (!recentWindow) {
if (this.AppConstants.platform == "macosx") {
let hiddenWindow = Services.appShell.hiddenDOMWindow;
// If there are no open browser windows, open a new one.
hiddenWindow.openDialog("chrome://browser/content/", "_blank",
"chrome,all,dialog=no", url);
}
Cu.reportError("Pocket: No open browser windows to openTabWithUrl");
return;
}